annotations: add WiP status annotations. #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per envoyproxy/envoy#9769. Signed-off-by: Harvey Tuch <htuch@google.com>
lizan
reviewed
Jan 24, 2020
udpa/annotations/status.proto
Outdated
| // Magic number in this file derived from top 28bit of SHA256 digest of | ||
| // "udpa.annotation.status". | ||
| extend google.protobuf.MessageOptions { | ||
| StatusAnnotation message_status = 222707719; |
There was a problem hiding this comment.
What's the use case for options other than file? I don't think we want that?
There was a problem hiding this comment.
Good question; I was thinking we could have WiP messages, but yeah, let's not allow this too fine grained, or it's going to be too confusing.
Signed-off-by: Harvey Tuch <htuch@google.com>
|
@lizan updated, PTAL, I have the next PR ready to go for integrating this with the Envoy API process. |
mattklein123
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per envoyproxy/envoy#9769.
Signed-off-by: Harvey Tuch htuch@google.com