Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Add support for associating projects with multiple TAGs #777

Closed
mrbobbytables opened this issue Jan 6, 2025 · 4 comments · Fixed by #780
Closed

[FEATURE REQUEST] Add support for associating projects with multiple TAGs #777

mrbobbytables opened this issue Jan 6, 2025 · 4 comments · Fixed by #780
Labels
enhancement New feature or request

Comments

@mrbobbytables
Copy link
Member

Currently there is a one-to-one mapping of CNCF TAG to project, however many projects actually span more than one TAG and may have multiple TAGs involved in their review when moving levels. As far as I can tell, the tag variable is only used for filters so hopefully a change like this would not be very disruptive.

Current:

item:
   name: foo
   ...
    extra:
      tag: bar

Desired:

item:
   name: foo
   ...
    extra:
      tag:
        - bar
        - baz
@mrbobbytables mrbobbytables added the enhancement New feature or request label Jan 6, 2025
@tegioz
Copy link
Collaborator

tegioz commented Jan 8, 2025

Hi @mrbobbytables 👋

This shouldn't be a problem. Some notes to keep in mind:

  • Projects' TAG is displayed in some places in the landscape (see screenshots below). In those cases we may still need to display just the "main" one if that makes sense in all cases, which could be the first one in the list. In the case of the item modal we could display additional ones below the item's description, like we do for additional categories (screenshot below).

  • In the stats page, there is a table that shows the distribution of projects by TAG. We should probably delete the total row as it could be confusing when the total doesn't add up.

FYI we have a feature that maps landscape categories/subcategories to TAGs. It's used to set a default TAG for an item when none is provided in the landscape.yml file. But this would work the same way, so nothing to worry about.

Image Image Image

@mrbobbytables
Copy link
Member Author

Awesome!

Replying to comments in line below:

Projects' TAG is displayed in some places in the landscape (see screenshots below). In those cases we may still need to display just the "main" one if that makes sense in all cases, which could be the first one in the list. In the case of the item modal we could display additional ones below the item's description, like we do for additional categories (screenshot below).

I think thats fine 👍

In the stats page, there is a table that shows the distribution of projects by TAG. We should probably delete the total row as it could be confusing when the total doesn't add up.

I think that'd be fine, especially as some TAGs are going away it'd be changing over time anyway.

tegioz added a commit that referenced this issue Jan 9, 2025
Closes #777

Signed-off-by: Sergio Castaño Arteaga <tegioz@icloud.com>
Signed-off-by: Cintia Sánchez García <cynthiasg@icloud.com>
Co-authored-by: Sergio Castaño Arteaga <tegioz@icloud.com>
Co-authored-by: Cintia Sanchez Garcia <cynthiasg@icloud.com>
cynthia-sg added a commit to cynthia-sg/landscape that referenced this issue Jan 9, 2025
Related to cncf/landscape2#777 and cncf/landscape2#780

Signed-off-by: Cintia Sánchez García <cynthiasg@icloud.com>
@tegioz tegioz closed this as completed in db32fd7 Jan 9, 2025
@tegioz
Copy link
Collaborator

tegioz commented Jan 9, 2025

This is ready @mrbobbytables.

For reference, this change also affected the generation of the items.csv and projects.csv data files, as well as some API responses. All of them now include all TAGs provided for a given item.

tegioz pushed a commit to cncf/landscape that referenced this issue Jan 9, 2025
Related to cncf/landscape2#777 and cncf/landscape2#780

Signed-off-by: Cintia Sánchez García <cynthiasg@icloud.com>
@mrbobbytables
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants