Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kubernetes v1.29 conformance results for EKS Anywhere #3049

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

abhay-krishna
Copy link
Contributor

Pre-submission checklist:

Please check each of these after submitting your pull request:

  • If this is a new entry, have you submitted a signed participation form?
  • Did you include the product/project logo in SVG, EPS or AI format?
  • Does your logo clearly state the name of the product/project and follow the other logo guidelines?
  • If your product/project is open source, did you include the repo_url?
  • Did you copy and paste the installation and configuration instructions into the README.md file in addition to linking to them?

For a full list of requirements, please refer to these sections of the docs: Contents of the PR, and Requirements.

Copy link

13 of 15 requirements have passed. Please review the following:

  • [FAIL] it appears that some tests are missing from the product submission
    • the following test(s) are missing:
      • [sig-network] Services should serve endpoints on same port and different protocols [Conformance]
  • [FAIL] it appears that some tests failed in the product submission
    • there appears to be 1 tests missing:
      • [sig-network] Services should serve endpoints on same port and different protocols [Conformance]

for a full list of requirements, please refer to these sections of the docs: content of the PR, and requirements.

@Cmierly
Copy link
Collaborator

Cmierly commented Feb 20, 2024

Please fix the issues with this PR so we can review and merge.

@abhay-krishna
Copy link
Contributor Author

abhay-krishna commented Feb 21, 2024

Please fix the issues with this PR so we can review and merge.

We are using Cilium as our CNI and are currently facing this issue (closed as duplicate but original issue not fixed) in our conformance testing. I saw a comment in another PR which also discussed this same known issue with Cilium. The test report files in this submission were generated by skipping this single test in our sonobuoy run, but it seems that causes the verification to fail, so for the time being we are blocked until this issue is fixed.

@taylorwaggoner
Copy link
Contributor

@hh @BobyMCbobs

@BobyMCbobs
Copy link
Collaborator

@hh @BobyMCbobs

There's a PR under way for this fix in Cilium
cilium/cilium#29521

@abhay-krishna
Copy link
Contributor Author

@hh @BobyMCbobs

There's a PR under way for this fix in Cilium cilium/cilium#29521

Yes, we are waiting for that change to get shipped in a new Cilium release, but it's hard to say when that will be, because there hasn't been any activity on the PR for some time.

@tnorlin
Copy link
Contributor

tnorlin commented May 15, 2024

@abhay-krishna It's been identified (if you are running with kube-proxy) that helm flag k8s.serviceProxyName=cilium will fix this test.

cilium config view |grep k8s-service-proxy-name
k8s-service-proxy-name                            cilium

@abhay-krishna
Copy link
Contributor Author

@abhay-krishna It's been identified (if you are running with kube-proxy) that helm flag k8s.serviceProxyName=cilium will fix this test.

cilium config view |grep k8s-service-proxy-name
k8s-service-proxy-name                            cilium

Thanks for the suggestion @tnorlin! I shall try that and update this PR after seeing how it goes.

Before trying it out though, I have a doubt. After reading the Cilium documentation, I have come to the understanding that the service proxy name acts as a kind of selector for services that Cilium should manage, based on the service.kubernetes.io/service-proxy-name label. If we now set the k8s.serviceProxyName option, does it mean Cilium will stop managing all the existing services since none of them have the service.kubernetes.io/service-proxy-name label by default? And does it mean I now need to explicitly add this label to every new service that I want Cilium to manage?

@abhay-krishna
Copy link
Contributor Author

@tnorlin Your suggestion worked! The test suite is passing now. Thanks for the guidance!

Ran 388 of 7407 Specs in 7059.525 seconds
SUCCESS! -- 388 Passed | 0 Failed | 0 Pending | 7019 Skipped
PASS

Ginkgo ran 1 suite in 1h57m40.880178553s
Test Suite Passed

Signed-off-by: Abhay Krishna Arunachalam <arnchlm@amazon.com>
Copy link

All requirements (15) have passed for the submission!

@tnorlin
Copy link
Contributor

tnorlin commented May 23, 2024

@abhay-krishna that was great news! No problem, we're in this together! I haven't tried deeper on the constraints, but I'm afraid that what's mentioned in the other repo holds true and we'll have to wait for the other PR to get the full feature set.

@Cmierly Cmierly merged commit 26fd07b into cncf:master Jun 5, 2024
2 checks passed
@Cmierly
Copy link
Collaborator

Cmierly commented Jun 5, 2024

You are now Certified Kubernetes

robinschneider pushed a commit to stackitcloud/k8s-conformance that referenced this pull request Jun 13, 2024
Signed-off-by: Abhay Krishna Arunachalam <arnchlm@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants