Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config for jenkins container #49

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Conversation

ktibi
Copy link
Contributor

@ktibi ktibi commented Feb 15, 2023

No description provided.

main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
variables.tf Show resolved Hide resolved
variables.tf Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
@jnonino jnonino added the enhancement New feature or request label Feb 16, 2023
@ktibi ktibi requested a review from jnonino February 16, 2023 15:38
@ktibi
Copy link
Contributor Author

ktibi commented Feb 16, 2023

Hi @jnonino Julian,

I change the task definition for EFS.

If we keep root_directory with your config, Fargate fail because it can't found the directory in the EFS.

I don't know if we can create directly the directory in the EFS with terraform. So by default I use / .

@jnonino
Copy link
Member

jnonino commented Feb 17, 2023

Hi @jnonino Julian,

I change the task definition for EFS.

If we keep root_directory with your config, Fargate fail because it can't found the directory in the EFS.

I don't know if we can create directly the directory in the EFS with terraform. So by default I use / .

Hi @ktibi, from what I remember the Jenkins image creates that directory when started running but that might be changed! I don't feel too confortable with using / if you can find an alternative that'd be great!!!

Working with Amazon EFS access points

Creating the root directory for an access point
If a root directory path for an access point doesn't exist on the file system, Amazon EFS automatically creates that root directory with the ownership and permissions specified.

Terraform efs_access_point

@jnonino
Copy link
Member

jnonino commented Feb 17, 2023

Hi @jnonino Julian,

I change the task definition for EFS.

If we keep root_directory with your config, Fargate fail because it can't found the directory in the EFS.

I don't know if we can create directly the directory in the EFS with terraform. So by default I use / .

Hi @ktibi, from what I remember the Jenkins image creates that directory when started running but that might be changed! I don't feel too confortable with using / if you can find an alternative that'd be great!!!

Working with Amazon EFS access points

Creating the root directory for an access point
If a root directory path for an access point doesn't exist on the file system, Amazon EFS automatically creates that root directory with the ownership and permissions specified.

@jnonino jnonino merged commit 8e0cfaa into cn-terraform:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

2 participants