-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor type system and add vector type, support stl index #682
Conversation
Signed-off-by: Alex Chi Z <iskyzh@gmail.com>
Signed-off-by: Alex Chi Z <iskyzh@gmail.com>
u r crazy🤣🤣🤣🤣oh my gosh |
the vector thing is for my upcoming vector db tutorial... feel free to ask me to drop if it is not ready for you to maintain. |
No, it is definitely sooooo cool to have vector support in bustub! 🥹 |
Wanted to further refactor index creation this semester now it's done already 🤯👍 |
Great! I will take a look later today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Signed-off-by: Alex Chi <iskyzh@gmail.com>
b004d6f
to
cb9c5ab
Compare
This pull request refactors the type system and supports more indexes in the system.
using
when creating index. users can choose to create hash table index or btree index.Column
. for example,VARCHAR(8)
will have type id as varchar and the width is stored in the column struct. expressions and planner have been refactored to take this into account. fixed several bugs related to data width inference.vector.slt
on how to use them. i.e.,SELECT ARRAY [1.0, 2.0];