Boosted Tau Production Changes for Ultra Legacy #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: Production/python/sampleConfig.py
…TauMLTools into BoostedTauULProductionCommits
kandrosov
requested changes
Mar 11, 2022
…duction code. Removes the redundant ED filter infrastructure, and changes the configuration to make useBoostedTauFilter an option given to TauTupleProducer. This option should now remove all non boosted tau type tau jets
Ntuples otherwise seem to get empty MVA evaluations
kandrosov
requested changes
Apr 7, 2022
Comment on lines
+118
to
+126
| from TauMLTools.Production.runTauIdMVA import runTauID | ||
| updatedBoostedTauName = "slimmedBoostedTausNewID" | ||
| runTauID(process, outputTauCollection=updatedBoostedTauName, inputTauCollection="slimmedTausBoosted", | ||
| toKeep = [ "2017v2", "dR0p32017v2", "newDM2017v2", "deepTau2017v2p1" ]) | ||
| process.boostedSequence = cms.Sequence( | ||
| getattr(process, updatedBoostedTauName+'rerunMvaIsolationSequence') * | ||
| getattr(process, updatedBoostedTauName) | ||
| ) | ||
| boostedTaus_InputTag = cms.InputTag(updatedBoostedTauName) |
There was a problem hiding this comment.
why do you rerun boosted tau ids for Run2 UL? It should be already included in miniAOD. At least it is the recommended way, as far as I know
There was a problem hiding this comment.
I tried running UL Ntuples without these lines, the MVA branches ended up empty (all 0), and it was causing issues with validation (I need to rerun a few ntuples now). These lines remedy the problem.
There was a problem hiding this comment.
This is strange. Perhaps the name of the stored mva ID is different? I think it is worth looking at more closely because if there are some problems with boosted taus in UL miniAODs, we need to make sure that it is documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some particularly circuitous commits adding some hacks and then removing them, this is the current status of the boosted tau effort UL production. The only real changes after the added and removed hacks is the introduction of some sample types and global tags, and a change to the
isRun2ULfunction. For Boosted Tau convenience I have added a quick filter that can be added into the production that simply checks that there is some boosted tau in the collection before attempting to do any Ntuplization, but if this is not desirable in the main repository, it can be removed from the commit.We will be attempting to make ntuples from all 4 UL time periods under this setup.
I will open a PR for the general boosted tau changes, but that similarly needs to be cleaned up to prevent superfluous merge conflicts from distracting from genuine ones.