Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Delete the object held by gROOT after we reset the globals. #186

Closed

Conversation

aandvalenzuela
Copy link

@cmsbuild
Copy link

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch cms/master/2a54a16c7c.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@aandvalenzuela
Copy link
Author

please test for CMSSW_13_3_ROOT6_X

For example this allows unique_ptr to be deleted first and thus inform TROOT if need be.

Fix root-project#13462
@cmsbuild
Copy link

Pull request #186 was updated.

@aandvalenzuela
Copy link
Author

please test for CMSSW_13_3_ROOT6_X

@cmsbuild
Copy link

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f61acc/34336/summary.html
COMMIT: bcc37fb
CMSSW: CMSSW_13_3_ROOT6_X_2023-08-16-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/root/186/34336/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test Miscellanea had ERRORS
---> test PrimaryVertex had ERRORS
---> test testDataFormatsScoutingRun3 had ERRORS
---> test testDataFormatsScoutingRun2 had ERRORS
and more ...

Comparison Summary

Summary:

  • You potentially added 9 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 2953 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3152915
  • DQMHistoTests: Total failures: 5816
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3147077
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 1 / 46 workflows

@aandvalenzuela
Copy link
Author

It seems tests are still failing due to root-project#13429

@hahnjo
Copy link

hahnjo commented Aug 18, 2023

It seems tests are still failing due to root-project#13429

Ok, thanks for testing. Was worth a try, but then I have to get a debugger going...

@aandvalenzuela
Copy link
Author

aandvalenzuela commented Aug 18, 2023

It seems tests are still failing due to root-project#13429

OK, thanks for testing. Was worth a try, but then I have to get a debugger going...

Right, I am trying to figure out why the reproducer does not work for you. Let's see if @smuzaffar can point out something on Monday. I think we might be missing one config step since the file is supposed to be public. Otherwise, I can give you access to one of our machines and set up a development area for you there.

Sorry for the inconvenience! :)

@hahnjo
Copy link

hahnjo commented Aug 23, 2023

I think this testing PR can be closed, the associated change was merged into ROOT master already last week. On the positive side, I made significant progress to understand root-project#13429: A workaround in CMSSW is proposed in cms-sw/cmssw#42628.

@smuzaffar
Copy link

@hahnjo , thanks a lot for looking in to the issue and providing a the cmssw fix cms-sw/cmssw#42628

@smuzaffar smuzaffar closed this Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants