Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r626: TBranchElement: no drilling through new members. #164

Closed
wants to merge 3 commits into from
Closed

r626: TBranchElement: no drilling through new members. #164

wants to merge 3 commits into from

Conversation

smuzaffar
Copy link

No description provided.

@pcanal
Add missing init of TIsAProxy::fNextLastSlot.
d63f977 
(thanks valgrind for pointing this out)
@pcanal
TBranchElement::InitInfo improve doc
7c6986d
@pcanal
TBranchElement: no drilling through new members.
40ffef6 
This resolved the problem seen at: cms-sw/cmssw#36908 (comment)
and fix root-project#9899.

The problem is the rules are applied to a data member nested inside an object nested inside
an STL collection that is a new data member of the class reco::HaloClusterCandidateHCAL,
since it is a new member compared to the layout on file, none of the objects; from the new
member down to the object on which the rules need to be run) are actually streamed and the
code gathering the information to run the rule got a bit lost ; it is likely (I am checking
as we speak) that in previous release the rule was not even attempted to be run ... which
might actually be the desired behavior in this specific case.

The solution is to have GatherArtificialElements stop drilling through data members which
are not stored in the existing TTree.
@cmsbuild
Copy link

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch cms/v6-26-00-patches/a9ebd7c.

@cmsbuild, @smuzaffar, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Author

test parameters:

  • full_cmssw = true
  • workflows_threading = 134.807,134.808,134.907,134.908
  • workflows = 134.807,134.808,134.907,134.908

@smuzaffar
Copy link
Author

please test for CMSSW_12_3_ROOT626_X

@smuzaffar smuzaffar mentioned this pull request Feb 18, 2022
Closed
@cmsbuild
Copy link

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c1e0f/22506/summary.html
COMMIT: 40ffef6
CMSSW: CMSSW_12_3_ROOT626_X_2022-02-17-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/root/164/22506/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c1e0f/22506/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c1e0f/22506/git-merge-result

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /pool/condor/dir_217322/jenkins/workspace/compare-root-files-short-matrix/data/PR-8c1e0f/134.807_RunDoubleEGPrpt2015C+RunDoubleEGPrpt2015C+HLTDR2_25ns+RECODR2_25nsreHLT_HIPM+HARVESTDR2
  • /pool/condor/dir_217322/jenkins/workspace/compare-root-files-short-matrix/data/PR-8c1e0f/134.808_RunSingleMuPrpt2015C+RunSingleMuPrpt2015C+HLTDR2_25ns+RECODR2_25nsreHLT_HIPM+HARVESTDR2
  • /pool/condor/dir_217322/jenkins/workspace/compare-root-files-short-matrix/data/PR-8c1e0f/134.907_RunDoubleEGPrpt2015D+RunDoubleEGPrpt2015D+HLTDR2_25ns+RECODR2_25nsreHLT_HIPM+HARVESTDR2
  • /pool/condor/dir_217322/jenkins/workspace/compare-root-files-short-matrix/data/PR-8c1e0f/134.908_RunSingleMuPrpt2015D+RunSingleMuPrpt2015D+HLTDR2_25ns+RECODR2_25nsreHLT_HIPM+HARVESTDR2

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 16678 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3965143
  • DQMHistoTests: Total failures: 181569
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3783550
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2.253 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11834.0 ): 2.249 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 6 / 48 workflows

@smuzaffar smuzaffar closed this Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smuzaffar @cmsbuild @pcanal