V622 pair offset #147
V622 pair offset #147
Conversation
The TClass generated by TStreamerInfo::GenerateInfoForPair is neither 'Interpreted' (cling likely does not, yet, have any information about that pair) nor loaded (the user did not request a dictionary for it) but need to have special treatment for those TClass. It is not clear whether this should be a new state. For now we introduce a new data member (`fIsSyntheticPair`) and don't increase the size of TClass instance by using a bit field.
…re provided. Since getting the right alignment and padding is hard (either use Cling/Clang with the associated memory cost and potential autoparsing or duplicating the platform dependent code that calculates it), we now only creates the synthetic TClass instance that represent and std::pair ***if and only*** the call is provided the actual offset of second and sizeof the pair. This information is known to compiled (and later interpreted) CollectionProxy, to TClass for class containing an std::pair (via their list of RealData which is recorded in the rootpcm) and to TClass::GetClass templated on the actual type (since the pair's data members are public)
Extract the offset and size of the pair and pass it along to raw TClass::GetClass
Use the data in fPRealData to calculate the offset and size of the pair
Note: If a StreamerInfo is loaded from a file and is the same information as an existing one, it is assigned the same "unique id" and we need to double check before removing it from the global list.
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch cms/v6-22-00-patches/d9daad3. @cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks. |
|
test parameters:
|
|
please test |
|
The tests are being triggered in jenkins.
|
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@pcanal , I am merging this in CMSSW v6.22 branch so that we can run full tests in IB |
|
@smuzaffar Some result seems to have come up. Does it mean we are all good or is there more to come? |
|
not really @pcanal , for PR tets we run in non-threaded mode so tests passigng here does not mean that there are no issue. This is now in IB whee we will relvals in threaded mode and there we will see if any issue pops up. Sometimes it takes few IBs to get threaded issues |
No description provided.