Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v6.22: Fix 6767 missing TStreamerInfo update upload TClass reload #146

Merged
merged 9 commits into from
Nov 8, 2020
Merged

v6.22: Fix 6767 missing TStreamerInfo update upload TClass reload #146

merged 9 commits into from
Nov 8, 2020

Conversation

smuzaffar
Copy link

to test root-project#6768 in cmssw

@pcanal
Enhance GenerateInfoForPair to respect the 'silent' flag.
2131d6b 
The silent flag to skip over error message about transient data member.

Also remove last traces of R__GenerateTClassForPair
@pcanal
Fix creation of void's TDataType
1e58792
@pcanal
In TGenCollectionProxy::Value::Value more elegantly handle case of fo…
a27fb12 
…rward declared classes.

Previously we issue a Fatal message about impossible code path.
@pcanal
More enhancing GenerateInfoForPair to respect the 'silent' flag.
2dc833e
@pcanal
Remove unused code in TClass::ReplaceWith
849d3df
@pcanal
TStreamerInfo::SetClass also updates the StreamerElement
09aabb0
@pcanal
Allow TClass to be created for known by the interpreter
95908e3 
this is used in the case where TStreamerInfo can not handle them.
@pcanal
Do not create TClass for better for forward declared types
4b018c5
@pcanal
TProtoClass deal with STL collection without Proxy.
20c74fa 
Now that we don't generate unusable collectionProxy (for example in the case one of the value type is 'only' forward
declared), we see (in roottest) case where the TProtoClass build the RealData but there is no (good) corresponding
data members.
@smuzaffar
Copy link
Author

smuzaffar commented Nov 7, 2020 •
edited
Loading

test parameters:

  • full_cmssw = true
  • release = CMSSW_11_2_X

@cmsbuild
Copy link

cmsbuild commented Nov 7, 2020

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch cms/v6-22-00-patches/50e52ba43c.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@smuzaffar
Copy link
Author

please test

@cmsbuild
Copy link

cmsbuild commented Nov 7, 2020 •
edited
Loading

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link

cmsbuild commented Nov 8, 2020

-1

Tested at: 20c74fa

CMSSW: CMSSW_11_2_ROOT622_X_2020-11-06-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f5f6f5/10567/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test MagneticFieldEngineTestDriver had ERRORS

@cmsbuild
Copy link

cmsbuild commented Nov 8, 2020

Comparison job queued.

@cmsbuild
Copy link

cmsbuild commented Nov 8, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f5f6f5/10567/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2544144
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2544121
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@smuzaffar
Copy link
Author

please test

@cmsbuild
Copy link

cmsbuild commented Nov 8, 2020 •
edited
Loading

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link

cmsbuild commented Nov 8, 2020

-1

Tested at: 20c74fa

CMSSW: CMSSW_11_2_X_2020-11-07-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f5f6f5/10569/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test MagneticFieldEngineTestDriver had ERRORS

@cmsbuild
Copy link

cmsbuild commented Nov 8, 2020

Comparison job queued.

@cmsbuild
Copy link

cmsbuild commented Nov 8, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f5f6f5/10569/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2544144
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2544115
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@smuzaffar smuzaffar merged commit 68367bf into cms-sw:cms/v6-22-00-patches/50e52ba43c Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available externals-pending orp-pending pending-signatures tests-rejected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smuzaffar @cmsbuild @pcanal