-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BeamSpot Fitter: added parameters to the migrad functor to supersede EDM defaults #9853
BeamSpot Fitter: added parameters to the migrad functor to supersede EDM defaults #9853
Conversation
… Minuit changed them after V5.32)
A new Pull Request was created by @rmanzoni (Riccardo Manzoni) for CMSSW_7_4_X. BeamSpot Fitter: added parameters to the migrad functor to supersede EDM defaults It involves the following packages: RecoVertex/BeamSpotProducer @diguida, @cvuosalo, @cerminar, @cmsbuild, @slava77, @mmusich can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
Hi @davidlange6, is this PR meant to be still pending or it simply slipped out of sight? Thanks |
it needed validation n a development release - that can happen this week I guess (in 750 for example).
|
+1 |
…M_Fix BeamSpot Fitter: added parameters to the migrad functor to supersede EDM defaults
back port of
#9852