-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor RecoTrackSelector and RecoTrackRefSelector #9798
Refactor RecoTrackSelector and RecoTrackRefSelector #9798
Conversation
…to RecoTrackSelectorBase I will soon add a third variant, and without the refactoring (as suggested by a comment in RecoTrackRefSelector) the code would become even more messy.
A new Pull Request was created by @cmsbuild for CMSSW_7_6_X. Refactor RecoTrackSelector and RecoTrackRefSelector It involves the following packages: CommonTools/RecoAlgos @cmsbuild, @cvuosalo, @vadler, @monttj, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 Refactoring RecoTrackSelector and RecoTrackRefSelector code. There should be no change in run-time behavior. #9658, the 75X version of this PR, was already approved by Reco. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2015-06-23-1100 show no significant differences, as expected. |
+1 |
1 similar comment
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request will be automatically merged. |
Refactor RecoTrackSelector and RecoTrackRefSelector
This PR refactors the commonalities of RecoTrackSelector and RecoTrackRefSelector to a new base class (RecoTrackSelectorBase; as suggested by a comment in RecoTrackRefSelector). I'm planning to add a third variant (reading tracks through View), and without the refactoring the code would become even more messy. I also took the opportunity to do a similar refactoring of the configuration parameters. I took this separate from the other developments in the hope of smoother integration for purely technical changes.
Tested in CMSSW_7_5_X_2015-06-14-2300, no changes expected in results.
@rovere @VinInn
Automatically ported from CMSSW_7_5_X #9658 (original by @makortel).