Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and update of pede param plotting macros #9711

Merged
merged 2 commits into from
Jun 23, 2015
Merged

Fix and update of pede param plotting macros #9711

merged 2 commits into from
Jun 23, 2015

Conversation

mschrode
Copy link

  • Fix compilation in ROOT6
  • Modify default output: one canvas per plot, stored as pdf
  • Modify default style
  • Add some steering scripts for easy plotting

@uhh2-bot
Pede param plotting macros
9722886 
- Fix compilation in ROOT6
- Modify default output: one canvas per plot, stored as pdf
- Modify default style
@uhh2-bot
Add some steering scripts for pede param plots
45f95dd
@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Jun 21, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mschrode (Matthias Schroeder) for CMSSW_7_5_X.

Fix and update of pede param plotting macros

It involves the following packages:

Alignment/MillePedeAlignmentAlgorithm

@cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @frmeier, @tlampen this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mschrode mschrode mentioned this pull request Jun 21, 2015
Merged
@diguida
Copy link
Contributor

diguida commented Jun 22, 2015

please test

@mmusich
Copy link
Contributor

mmusich commented Jun 22, 2015

@cmsbuild plese test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 45f95dd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9711/5601/summary.html

@mmusich
Copy link
Contributor

mmusich commented Jun 22, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9711/5601/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

This was referenced Jun 23, 2015
Merged
Closed
@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jun 23, 2015
@cmsbuild
Merge pull request #9711 from mschrode/pedeplottingmacros_75X
e297cb9 
Fix and update of pede param plotting macros
@cmsbuild cmsbuild merged commit e297cb9 into cms-sw:CMSSW_7_5_X Jun 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved comparison-available fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.
6 participants
@mschrode @cmsbuild @diguida @mmusich @davidlange6 @uhh2-bot