Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistently use momentum at POCA for PFDisplacedVertex momentum computations (same as #9703 from 74X) #9704

Merged

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Jun 20, 2015

other than fixing a technical bug, it also allows to run (particleFlowDisplacedVertexCandidate+particleFlowDisplacedVertex) on AOD.

The difference in results is at numerical roundoff level (checked on ~1K events in ttbar with PU=35).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_7_5_X.

consistently use momentum at POCA for PFDisplacedVertex momentum computations (same as #9703 from 74X)

It involves the following packages:

DataFormats/ParticleFlowReco

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@bachtis, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor Author

slava77 commented Jun 20, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor Author

slava77 commented Jun 23, 2015

+1

for #9704 e31c8c3

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jun 24, 2015
…Frereco

 consistently use momentum at POCA for PFDisplacedVertex momentum computations (same as  #9703  from 74X)
@cmsbuild cmsbuild merged commit 2260434 into cms-sw:CMSSW_7_5_X Jun 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants