-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consistently use momentum at POCA for PFDisplacedVertex momentum computations (same as #9703 from 74X) #9704
consistently use momentum at POCA for PFDisplacedVertex momentum computations (same as #9703 from 74X) #9704
Conversation
A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_7_5_X. consistently use momentum at POCA for PFDisplacedVertex momentum computations (same as #9703 from 74X) It involves the following packages: DataFormats/ParticleFlowReco @cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
…Frereco consistently use momentum at POCA for PFDisplacedVertex momentum computations (same as #9703 from 74X)
other than fixing a technical bug, it also allows to run (particleFlowDisplacedVertexCandidate+particleFlowDisplacedVertex) on AOD.
The difference in results is at numerical roundoff level (checked on ~1K events in ttbar with PU=35).