-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace getProcessParameterSet in PrescaleService #9702
Replace getProcessParameterSet in PrescaleService #9702
Conversation
This is part of a small migration to remove the function getProcessParameterSet from CMSSW. It relies on a static global that causes multithreading issues. And it does not work correctly with SubProcesses. I replaced the function with an alternative that should behave in exactly the same way.
A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_5_X. Replace getProcessParameterSet in PrescaleService It involves the following packages: FWCore/PrescaleService @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. |
Please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
Comparison is ready There are some workflows for which there are errors in the baseline: |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Replace getProcessParameterSet in PrescaleService
This is part of a small migration to remove
the function getProcessParameterSet from
CMSSW. It relies on a static global that causes
multithreading issues. And it does not work
correctly with SubProcesses.
I replaced the function with an alternative that
should behave in exactly the same way.