Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for BX number = 3564, descriptions of plugins, configuration updates and new histograms #9690

Merged
merged 8 commits into from
Jul 29, 2015

Conversation

venturia
Copy link
Contributor

Code which rely on BX number has been fixed to allow BX number = 3564.
Added the description of several plugins
Updates of the configurations to use conddb v2
Added new histograms to monitor the BX and orbit number differences between SCAL and TCDS

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @venturia for CMSSW_7_4_X.

Fix for BX number = 3564, descriptions of plugins, configuration updates and new histograms

It involves the following packages:

DPGAnalysis/SiStripTools
Validation/RecoVertex

@cmsbuild, @vadler, @danduggan, @deguio, @monttj can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @cerati, @istaslis, @threus, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Jun 24, 2015

please test

@deguio
Copy link
Contributor

deguio commented Jun 24, 2015

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@monttj
Copy link
Contributor

monttj commented Jun 26, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jul 29, 2015
Fix for BX number = 3564, descriptions of plugins, configuration updates and new histograms
@cmsbuild cmsbuild merged commit 2130c02 into cms-sw:CMSSW_7_4_X Jul 29, 2015
@venturia venturia deleted the dpganalysis_sistriptools-74x branch September 9, 2016 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants