-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VID Feature Requests for 75X #9659
Conversation
A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_5_X. VID Feature Requests for 75X It involves the following packages: CommonTools/Utils @cmsbuild, @cvuosalo, @vadler, @monttj, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
-1 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15.log ----- Begin Fatal Exception 18-Jun-2015 20:25:12 CEST----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=MixingModule label='mix' Exception Message: RootEmbeddedFileSequence no input files specified for secondary input source. ----- End Fatal Exception ------------------------------------------------- you can see the results of the tests here: |
+1 |
50 MB is not something to just swallow.. (especially in 74x) @lgray can you confirm what this is?
|
@davidlange6 3 ID MVAs being run for the new EGM IDs. Since this is on top of the usual memory usage of MiniAOD 50 MB is relatively large, but in absolute terms comparing to RSS limits I imagine it's not? Notably this doesn't happen in 74X because these IDs are not run in MiniAOD production. |
is 3% of the total budget.. indeed its importance depends on where one is relative to the budget:) [which we are over partly due to many more memory intensive MVAs in reco] - but by 75x we can plan to be running multicore on the tier0.
|
OK, noted. |
not to me.
|
@franzoni Could you please take a look here and +1 if you find things agreeable? Thanks! |
VID Feature Requests for 75X
This pull request implements the following requested features in VID:
The middle two points are implemented as "vid::CutFlowResult" which is a digest that implements a masking and value-retrieval interface.
This pull request now also implements "MINIAODfromMINIAOD" data reprocessing and VID-by-value, which only functions for objects with all necessary information embedded in some way (except for vertices, etc which are always in the event).
@ikrav @cmkuo @gpetruc