Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn CCC off everywhere, not only in iterative tracking, in RunI-like customization snippet. #9418

Merged

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Jun 2, 2015

This PR is not critical: it will turn CCC of also for convertions. Iterative tracking has already CCC off in the RunI-like customization snippet.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2015

A new Pull Request was created by @rovere (Marco Rovere) for CMSSW_7_4_X.

turn CCC off everywhere, not only in iterative tracking, in RunI-like customization snippet.

It involves the following packages:

RecoTracker/Configuration

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @VinInn, @appeltel, @mschrode, @gpetruc, @cerati, @dgulhan, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cvuosalo
Copy link
Contributor

cvuosalo commented Jun 3, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2015

-1
Tested at: 6042319
When I ran the RelVals I found an error in the following worklfows:
50202.0 step2

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50+MINIAODMCUP1550/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50+MINIAODMCUP1550.log
----- Begin Fatal Exception 03-Jun-2015 21:32:59 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digitisation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
RootInputFileSequence::readOneRandom(): no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9418/5265/summary.html

@slava77
Copy link
Contributor

slava77 commented Jun 4, 2015

+1

for #9418 6042319

  • checked locally in CMSSW_7_4_4_patch2 /test area sign744b/ looking at 1000.0 (prompt reco) workflow with customiseForRunI applied for 0 T PU~30 run 200781 and for the default 1000.0 input with 3.8 T and lowish PU (2011A, run 165121). Just from the configuration already, as expected from the PR description, the effect is also on the conversionStepTracks
    • for 3.8 T, as expected, there are some small changes in conversion tracks and in objects downstream. This is intended, anyways.
    • for 0T there are essentially no conversionStepTracks (regular generalTrack reco already picks up essentially everything reconstructable). So, there is no effect; no changes were observed in monitored quantities on the 100 tested events. I think this PR is insignificant in context of B=0T data taking.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Jun 5, 2015
turn CCC off everywhere, not only in iterative tracking, in RunI-like customization snippet.
@davidlange6 davidlange6 merged commit c4d7fb4 into cms-sw:CMSSW_7_4_X Jun 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants