-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kCanRebin is replaced with SetCanExtend in online beamspot code for dqm #9416
kCanRebin is replaced with SetCanExtend in online beamspot code for dqm #9416
Conversation
A new Pull Request was created by @sushilchauhan for CMSSW_7_4_X. kCanRebin is replaced with SetCanExtend in online beamspot code for dqm It involves the following packages: DQM/BeamMonitor @cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks. |
+1 |
@sushilchauhan |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
Comparison is ready There are some workflows for which there are errors in the baseline: |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
…pre5 replaced kCanRebin with SetCanExtend for beamspot code for online DQM as done in PR #9416
+1 |
kCanRebin is replaced with SetCanExtend in online beamspot code for dqm
This PR should not have been merged into 7_4_ROOT5_X. It is ROOT6 specific. It breaks 7_4_ROOT5_X. |
kCanRebin is replaced with SetCanExtend in online BeamSpot code for DQM to work properly in 74x