Adding prescale index and L1 tables with per-type data #9301
Conversation
|
A new Pull Request was created by @avetisya for CMSSW_7_4_X. Adding prescale index and L1 tables with per-type data It involves the following packages: HLTrigger/JSONMonitoring @Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks. |
|
please test |
| @@ -26,10 +26,10 @@ TriggerJSONMonitoring::TriggerJSONMonitoring(const edm::ParameterSet& ps) | |||
|
|
|||
| triggerResultsToken_ = consumes<edm::TriggerResults>(triggerResults_); | |||
|
|
|||
| if (ps.exists("L1Results")) level1Results_ = ps.getParameter<edm::InputTag>("L1Results"); //DS | |||
| else level1Results_ = edm::InputTag("hltGtDigis"); //DS | |||
| if (ps.exists("L1Results")) level1Results_ = ps.getParameter<edm::InputTag>("L1Results"); | |||
There was a problem hiding this comment.
Putting the proper value into the fillDescriptions(), the ps.exists is not needed!
Like-wise for the other ps.exists!
|
The tests are being triggered in jenkins. |
cmsbuild
added
comparison-pending
hlt-pending
orp-pending
and removed
comparison-pending
hlt-pending
orp-pending
pending-signatures
tests-started
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
Hi Aram @avetisya |
|
Hi Martin, The 75X version is #9441 . -- Aram |
|
@avetisya |
|
+1 |
Adding prescale index and L1 tables with per-type data
This adds the prescale index (as seen by the CMSSW framework) and L1 tables split by Physics, Calibration and Random. The prescale index is currently passes the "sample" operation to hltd and the transfer system so the latter will take it from a random file. The functionality to compare across all files and verify that it is the same is not currently present, although this is done in the CMSSW code so at least if it changes for the same process, we will know.
There were also a few changes to clean up the code and remove some ambiguities. The iSummary variables are now explicitly initialized at the beginning of each lumi section. Also, L1Accept is now L1AlgoAccept to clarify that this is for the algorithm bits only rather than all bits.