Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Electron stream plugin fix #9256

Merged
merged 3 commits into from
Jun 8, 2015
Merged

Electron stream plugin fix #9256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4ce38b
updates for electrons stream
rgerosa May 15, 2015
83090c8
moved plugins from src to plugins folder
May 21, 2015
bdfeaff
fixed include of ElectronStream plugin, moving part of include statem…
May 26, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions Calibration/EcalAlCaRecoProducers/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,3 @@
<use name="DataFormats/Math"/>
<use name="DataFormats/EcalDetId"/>
<use name="DataFormats/TrackReco"/>
# for FED list selector
<use name="CalibFormats/SiStripObjects"/>
<use name="CalibCalorimetry/HcalAlgos"/>
<use name="CondFormats/EcalObjects"/>
<use name="CondFormats/DataRecord"/>
<use name="CondFormats/HcalObjects"/>
<use name="CondFormats/SiPixelObjects"/>
<use name="Geometry/CaloGeometry"/>
<use name="Geometry/CaloTopology"/>
<use name="RecoEcal/EgammaCoreTools"/>
<use name="TrackingTools/TrackAssociator"/>
9 changes: 9 additions & 0 deletions Calibration/EcalAlCaRecoProducers/plugins/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,13 @@
<use name="DataFormats/TrackReco"/>
<use name="CommonTools/UtilAlgos"/>
<use name="DataFormats/RecoCandidate"/>
# for FED list selector
<use name="DataFormats/EgammaCandidates"/>
<use name="CondFormats/SiPixelObjects"/>
<use name="CalibFormats/SiStripObjects"/>
<use name="CalibFormats/HcalObjects"/>
<use name="Geometry/EcalMapping"/>
<use name="Geometry/CaloGeometry"/>
<use name="RecoEcal/EgammaCoreTools"/>
<use name="CalibTracker/Records"/>
<flags EDM_PLUGIN="1"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was trying to figure out why all of these dependencies came in. Could you clean up the header file for the moved plugin to use only the incldues that it needs (which is almost none of them- use "class blah;" instead) and add the minimal set of headers to the cc file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear David,
I'm cleaning it a bit, but a large number of includes are needed and the BuildFile will not be reduced.
Are you suggesting to replace
use name= with use class= ?
Can you point me to an example please?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://stackoverflow.com/questions/8632430/about-class-declaration-in-header-file-c

Loading