Multi-threading support added for Heavy Ions HLT modules

[kkrajczar]

This is a 7_4_X backport of PR #9071

[cmsbuild]

A new Pull Request was created by @kkrajczar (Krisztian Krajczar) for CMSSW_7_4_X.

Multi-threading support added for Heavy Ions HLT modules

It involves the following packages:

RecoEcal/EgammaClusterProducers
RecoHI/HiEgammaAlgos

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @jazzitup, @argiro, @appeltel, @richard-cms, @yenjie, @kurtejung, @lgray, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

-1
Tested at: 790edb2
you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9072/4669/summary.html

[cvuosalo]

+1

For #9072 790edb2

Migration of HI HLT code to support multi-threading. It should not change monitored physics quantities. This PR is the same as #9071, which is aimed at 75X.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-05-12-2300 show no significant differences, as expected.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[kkrajczar]

I think this PR has been forgotten, the orp signoff is pending since ~16 days. The 75X counterpart of this PR has already been merged.

[davidlange6]

@kkrajczar - merging in 75x is not sufficient for a backport - needs to be validated first (so in 750pre5). In any case why is this PR important for 74x?

[kkrajczar]

Dear David,

Thank you for the comment. I don't know what the precise timeline/relevance for this PR to get into 74X is apart from the fact that the module from this PR is used at HLT. I thought not having this PR integrated 16 days after it was signed (except by the orp) was unusual, and that it might have been overlooked. If that is not the case, and everything goes as expected, I'm sorry about the noise.

Cheers,
Krisztian

[davidlange6]

+1