Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event plane data format for Heavy Ion #9022

Merged
merged 46 commits into from
May 23, 2015

Conversation

BetterWang
Copy link
Contributor

Updated Event plane data format for Heavy Ion Run2.
Updated flattening and calibration.
We have a twiki page, and slides.

@BetterWang
Copy link
Contributor Author

@ssanders50 @yetkinyilmaz

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone May 9, 2015
@BetterWang
Copy link
Contributor Author

@slava77 , I can confirm that the default level is correct.
The DQM module is outdated, and will be updated after discussion with the global observable group.

@slava77
Copy link
Contributor

slava77 commented May 22, 2015

+1

for #9022 6009dd2

  • code changes affect only HI workflows;
  • code review comments were addressed and no additional static analyzer issues are introduced
  • jenkins tests passed OK; for comparisons with the baseline I'm relying on local tests (jenkins comparison jobs got stuck anyways)
  • tested locally in CMSSW_7_5_0_pre4 /test area sign549/ also with 100 events in workflow 140.53 and 140.0
    • technical performance numbers were posted earlier in the thread
    • comparisons with baseline show differences only in the parts related to hiEvtPlane; DQM plots in Centrality/EventPlane are now picking up consistently "-10" default values for a default (unfilled) level index.
  • DQM code still needs updates

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants