ROOT Macros need to compile in ROOT6 (Sim)

[wmtan]

Do not forward this PR to CMSSW_7_5_ROOT5_X. It is ROOT6 only.
In ROOT6 macros are processed by cling, rather than CINT. Over 500 CMSSW macros do not compile in ROOT6. Since that is too many macros to be fixed centrally, it was decided by David Lange to centrally fix only those 45 macros with compilation errors that have been modified since the switch over to git, since those are the ones most likely to be used. Only two of these 45 macros are in the Sim L2 category. This pull request fixes both of them.
NOTE: These two macros are unusual in the failure to compile with ROOT6 is due to a change in the ROOT API, and not due to CINT/cling differencess.

[cmsbuild]

A new Pull Request was created by @wmtan for CMSSW_7_5_X.

ROOT Macros need to compile in ROOT6 (Sim)

It involves the following packages:

TauAnalysis/MCEmbeddingTools

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[civanch]

please test

[civanch]

+1

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

[nclopezo]

Since this PR is fully-signed and it is only orp-pending. I created and merged #8728 to prevent these changes to be forwarded to CMSSW_7_5_ROOT5_X.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8709/4199/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

[davidlange6]

+1

[davidlange6]

@wmtan - could you check and confirm that there are some changes that are really root6 specific in this PR and the others? Thinking about it now, I doubt it, but I didn’t look through all of the changes…

On Apr 13, 2015, at 9:30 PM, wmtan notifications@github.com wrote:

Do not forward this PR to CMSSW_7_5_ROOT5_X. It is ROOT6 only.
In ROOT6 macros are processed by cling, rather than CINT. Over 500 CMSSW macros do not compile in ROOT6. Since that is too many macros to be fixed centrally, it was decided by David Lange to centrally fix only those 45 macros with compilation errors that have been modified since the switch over to git, since those are the ones most likely to be used. Only two of theose 45 macros are in the Sim L2 category. This pull request fixes both of them.

You can view, comment on, or merge this pull request online at:

#8709

Commit Summary

• Macros need to compile in ROOT6
File Changes

• M TauAnalysis/MCEmbeddingTools/macros/makeEmbeddingKineReweightLUTs2.C (4)
• M TauAnalysis/MCEmbeddingTools/macros/makeEmbeddingValidationPlots.C (2)
Patch Links:

• https://github.com/cms-sw/cmssw/pull/8709.patch
• https://github.com/cms-sw/cmssw/pull/8709.diff
—
Reply to this email directly or view it on GitHub.

[wmtan]

In this PR, the change to the first file, TauAnalysis/MCEmbeddingTools/macros/makeEmbeddingKineReweightLUTs2.C is ROOT6 specific. The change to the second file is not,