Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable MiniAOD validation, in default validation switch GenJets to GenJetsNoNu as new default #8674

Conversation

webermat
Copy link
Contributor

@webermat webermat commented Apr 7, 2015

...validations. Back port for 74X, since 74X is forseen for a test run of MiniAOD validations (75X PR is #8672) .

The MiniAOD validation modules are now put in file
Configuration/StandardSequences/python/Validation_cff.py
into validationMiniAOD instead of the prevalidationMiniAOD sequence

Reorganisation for the MET Harvesting to include a PostProcessor for an overall MET Resolution summary plot and a MET PostProcessorHarvester to compare output of RECO and MiniAOD validations.

Tested successfully locally using the mentioned unscheduled Validation
runTheMatrix.py -l 11325 -i all

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2015

A new Pull Request was created by @webermat for CMSSW_7_4_X.

modifications to enable MiniAOD validation and compare RECO and MiniAOD ...

It involves the following packages:

Configuration/StandardSequences
Validation/Configuration
Validation/RecoJets
Validation/RecoMET

@civanch, @nclopezo, @cvuosalo, @mdhildreth, @cmsbuild, @franzoni, @deguio, @slava77, @danduggan, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @appeltel, @mmarionncern, @jdolen, @ahinzmann, @GiacomoSguazzoni, @rappoccio, @rovere, @VinInn, @Martin-Grunewald, @makortel, @nhanvtran, @schoef, @cerati, @mariadalfonso, @dgulhan, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8674/4118/summary.html
There are some workflows for which there are errors in the baseline:
25.0 step 4
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@webermat webermat changed the title modifications to enable MiniAOD validation and compare RECO and MiniAOD ... enable MiniAOD validation, in default validation switch GenJets to GenJetsNoNu as new default May 26, 2015
@slava77
Copy link
Contributor

slava77 commented May 26, 2015

+1

for #8674 10a17d1
this is the same topic branch as the signed off 75X PR #8672

I personally have doubts about changing the default validation configuration so late in 74X cycle; but DQM signed off. So, should be OK, I suppose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants