-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjustments for using MixingModule for Heavy Ion simulations #6982
Conversation
merging? |
Adjustments for using MixingModule for Heavy Ion simulations
@yetkinyilmaz - looks like this PR broke a number of HI workflows. Please have a look - e.g. - |
This is totally expected, but I should have temporarily disabled these workflows in the PR. The new methods are completely different, so these workflows will have to be almost completely written from scratch - cleaning the old style HiMixingModule related stuff (see the PR description). |
Hi, This PR seems to break our addON HLT/HIon test, see here: specifically the test: Can you please have a look and suggest a fix? |
Just answered in the sw thread, yes, we will PR a fix soon. On 1/19/15 11:42 AM, Martin Grunewald wrote:
|
Hello @yetkinyilmaz , 'IOMC.EventVertexGenerators.VtxSmearedRealisticHI2011Collision_cfi', has been removed which holds the default SIM beam-spot for heavy ion (as verbally agreed at the orp wtih @mandrenguyen, see also the discussion in #6751). Removing that line breaks the consistency of VtxSmeared.py . The breaking was not detected by tests which recycle the GEN-SIM for HI. 7_4_0_pre5 still had the line => re-doing the GEN-SIM relval was ok. The first release w/o the line is 7_4_0_pre5_ROOT6, and the subsequent IB's. Why was the line removed ? Any change in LHC BS expectations for HI run2? |
Hi Giovanni, On 1/20/15 11:11 PM, Giovanni Franzoni wrote:
|
Thanks, @yetkinyilmaz. |
This is the minimum updates in order to be able to run MixingModule for Heavy-Ion embedding studies.
Presented in https://indico.cern.ch/event/344150/
The main difference from pp pile-up simulations is that it runs mixing in gen-level, and the sim-level mixing in next process happens in playback mode. Event contents are updated accordingly. ConfigBuilder is adjusted so that the commands here define the workflows successfully:
https://github.com/CmsHI/cmssw/blob/mix_74X_08/HeavyIonsAnalysis/Mixing/test/runChainTemp.sh
Tested on
slc6_amd64_gcc491
by
runTheMatrix.py -s --useInput all
runTheMatrix.py -l 140.53
To be followed up in later pull-requests: