Add Mother Indices to LHEPart #47075
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47075/43246
|
|
A new Pull Request was created by @pianonick411 for master. It involves the following packages:
@cmsbuild, @ftorrresd, @hqucms can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
enable nano |
hqucms
reviewed
Jan 10, 2025
| @@ -66,11 +66,21 @@ class LHETablesProducer : public edm::global::EDProducer<> { | |||
| std::vector<int> vals_pid; | |||
| std::vector<int> vals_status; | |||
| std::vector<int> vals_spin; | |||
| std::vector<Short_t> vals_firstMotherIdx; | |||
| std::vector<Short_t> vals_lastMotherIdx; | |||
There was a problem hiding this comment.
Better to use int16_t instead of Short_t to be more explicit about the type.
| outPart->addColumn<Short_t>( | ||
| "firstMotherIdx", vals_firstMotherIdx, "Index of this particle's first mother in the LHEPart collection"); | ||
| outPart->addColumn<Short_t>( | ||
| "lastMotherIdx", vals_lastMotherIdx, "Index of this particle's last mother in the LHEPart collection"); |
There was a problem hiding this comment.
Also here -- better to use int16_t instead of Short_t.
|
please test |
|
+1 Size: This PR adds an extra 40KB to repository Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
cmsbuild
added
tests-pending
code-checks-pending
and removed
tests-approved
code-checks-approved
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47075/43266
|
|
Pull request #47075 was updated. @cmsbuild, @ftorrresd, @hqucms can you please check and sign again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
The indices of a particle's mother are not currently stored in the LHEPart collection.
This PR would add two lists of indices to the LHEPart collection:
The ability to track an LHE particle's ancestry is necessary for performing matrix-element calculations as done in HIG-19-009 and HIG-21-013 for the purposes of reweighting. Future Higgs property measurements in H -> 4l and other channels will require this additional information.
I have discussed the code of this PR with the following members of the HZZ group: Nicola Amapane (@namapane), and Jeffrey Davis (@jdavis36).
PR validation:
The code was tested on a sample of ZH, (H -->ZZ-->4l) events from /ZHto2Zto4L_M125_TuneCP5_13p6TeV_powheg2-minlo-HZJ-JHUGenV752-pythia8/Run3Summer22MiniAODv4-130X_mcRun3_2022_realistic_v5-v2/MINIAODSIM in CMSSW_13_3_3.
A ZH sample was chosen so that the LHE history was sufficiently complex.
It was verified that the indices stored in the output nanoAOD file correspond to the same particle in the input miniAOD.
According to the size report, each of the 2 new variables adds 0.1 b/item; in this sample there are in average 14 items/evt, so the total size increase is be 2.8 b/evt, which is a very small addition.