Replace TAcc with explicit accelerator type

[fwyzard]

PR description:

Replace the TAcc template with the explicit accelerator type (Acc1D, Acc2D, or Acc3D).

PR validation:

The code builds.

[fwyzard]

please test

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46916/42977

• There are other open Pull requests which might conflict with changes you have proposed:
  • File HeterogeneousCore/AlpakaTest/plugins/alpaka/TestAlgo.dev.cc modified in PR(s): Add {Copy,Move}ToDeviceCache<T> class templates and moveToDeviceAsync function template #43969
  • File RecoLocalCalo/HGCalRecProducers/plugins/alpaka/HGCalLayerClustersSoAAlgoWrapper.dev.cc modified in PR(s): ALPAKA CLUE2D Code Heterogenous Code Porting #46786

[cmsbuild]

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

• DataFormats/SiPixelClusterSoA (heterogeneous, reconstruction)
• DataFormats/SiPixelDigiSoA (heterogeneous, reconstruction)
• DataFormats/TrackSoA (heterogeneous, reconstruction)
• DataFormats/TrackingRecHitSoA (heterogeneous, reconstruction)
• DataFormats/VertexSoA (heterogeneous, reconstruction)
• EventFilter/EcalRawToDigi (reconstruction)
• HeterogeneousCore/AlpakaInterface (heterogeneous)
• HeterogeneousCore/AlpakaTest (heterogeneous)
• MagneticField/ParametrizedEngine (reconstruction)
• RecoLocalCalo/EcalRecProducers (reconstruction)
• RecoLocalCalo/HGCalRecProducers (upgrade, reconstruction)
• RecoLocalCalo/HcalRecProducers (reconstruction)

@Moanwar, @fwyzard, @jfernan2, @makortel, @mandrenguyen, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @ReyerBand, @VinInn, @VourMa, @abdoulline, @apsallid, @argiro, @bsunanda, @cseez, @denizsun, @dkotlins, @edjtscott, @felicepantaleo, @ferencek, @gpetruc, @hatakeyamak, @lecriste, @lgray, @makortel, @mariadalfonso, @missirol, @mmusich, @mroguljic, @mtosi, @namapane, @pfs, @rchatter, @rovere, @salimcerci, @sameasy, @sethzenz, @thomreis, @tsusa, @tvami, @vandreev11, @wang0jin, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Size: This PR adds an extra 96KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1aead/43390/summary.html
COMMIT: 53a0974
CMSSW: CMSSW_15_0_X_2024-12-11-0800/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46916/43390/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 123 differences found in the comparisons
• DQMHistoTests: Total files compared: 47
• DQMHistoTests: Total histograms compared: 3623082
• DQMHistoTests: Total failures: 2766
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3620296
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
• Checked 206 log files, 177 edm output root files, 47 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46916/42980

• There are other open Pull requests which might conflict with changes you have proposed:
  • File HeterogeneousCore/AlpakaTest/plugins/alpaka/TestAlgo.dev.cc modified in PR(s): Add {Copy,Move}ToDeviceCache<T> class templates and moveToDeviceAsync function template #43969
  • File RecoLocalCalo/HGCalRecProducers/plugins/alpaka/HGCalLayerClustersSoAAlgoWrapper.dev.cc modified in PR(s): ALPAKA CLUE2D Code Heterogenous Code Porting #46786
  • File RecoParticleFlow/PFClusterProducer/plugins/alpaka/PFClusterECLCC.h modified in PR(s): Extend CMSSW to a distributed application over MPI #32632
  • File RecoParticleFlow/PFClusterProducer/plugins/alpaka/PFClusterSoAProducerKernel.dev.cc modified in PR(s): Extend CMSSW to a distributed application over MPI #32632

[cmsbuild]

Pull request #46916 was updated. @Moanwar, @cmsbuild, @fwyzard, @jfernan2, @makortel, @mandrenguyen, @srimanob, @subirsarkar can you please check and sign again.

[cmsbuild]

-1

Failed Tests: ClangBuild
Size: This PR adds an extra 476KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1aead/43871/summary.html
COMMIT: bd19ee4
CMSSW: CMSSW_15_0_X_2025-01-20-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46916/43871/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' /usr/bin/time -v scram build -k -j 32 COMPILER='llvm compile'

>> Entering Package RecoLocalTracker/SiPixelRecHits
>> Entering Package RecoParticleFlow/PFClusterProducer
>> Entering Package RecoParticleFlow/PFRecHitProducer
>> Entering Package RecoTracker/PixelSeeding
>> Compile sequence completed for CMSSW CMSSW_15_0_X_2025-01-20-1100
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
Command exited with non-zero status 1
	Command being timed: "scram build -k -j 32 COMPILER=llvm compile BUILD_LOG=yes"
	User time (seconds): 4359.86
	System time (seconds): 484.61
	Percent of CPU this job got: 922%


[fwyzard]

I've backed out the changes from RecoTracker/PixelSeeding, as that code needs a lot of refactoring 🤷🏻 ...

[fwyzard]

please test

[fwyzard]

+heterogeneous

optimistically :-)

[cmsbuild]

+1

Size: This PR adds an extra 64KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1aead/43884/summary.html
COMMIT: 8506481
CMSSW: CMSSW_15_0_X_2025-01-20-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46916/43884/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 131 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3932183
• DQMHistoTests: Total failures: 2328
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3929835
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 218 log files, 189 edm output root files, 50 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• You potentially removed 24 lines from the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 7
• DQMHistoTests: Total histograms compared: 53071
• DQMHistoTests: Total failures: 28
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 53043
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
• Checked 24 log files, 30 edm output root files, 7 DQM output files
• TriggerResults: no differences found

[fwyzard]

@jfernan2 @Moanwar this is ready to be merged.

[jfernan2]

+1

[Moanwar]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1