Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customiseWithTimeMemoryInfo() function to TimeMemoryInfo.py #46883

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Dec 5, 2024

PR description:

To work around the test failure in #46859 (comment)

PR validation:

None

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2024

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • Validation/Performance (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

This will allow the customization to be applied together with other customizations that may use the customise() function name.
@makortel makortel changed the title Add customizeWithTimeMemoryInfo() function to TimeMemoryInfo.py Add customiseWithTimeMemoryInfo() function to TimeMemoryInfo.py Dec 5, 2024
@makortel makortel changed the title Add customiseWithTimeMemoryInfo() function to TimeMemoryInfo.py Add customiseWithTimeMemoryInfo() function to TimeMemoryInfo.py Dec 5, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2024

Pull request #46883 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again.

@makortel
Copy link
Contributor Author

makortel commented Dec 6, 2024

@cmsbuild, please test

@makortel
Copy link
Contributor Author

makortel commented Dec 6, 2024

+core

(behavior was really tested as part of #46859)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2024

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46c259/43301/summary.html
COMMIT: fa6807f
CMSSW: CMSSW_15_0_X_2024-12-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46883/43301/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mandrenguyen
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants