Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CaloParticle class version after #46678 #46851

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Dec 3, 2024

PR description:

Title says it all, addresses #46678 (comment) and following

PR validation:

Run phase-2 HLT timing workflow successfully

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Dec 3, 2024

type bug-fix

@mmusich
Copy link
Contributor Author

mmusich commented Dec 3, 2024

test parameters:

  • enable = hlt_p2_integration, hlt_p2_timing

@mmusich
Copy link
Contributor Author

mmusich commented Dec 3, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2024

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • SimDataFormats/CaloAnalysis (simulation)

@civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@ReyerBand, @apsallid, @bsunanda, @fabiocos, @felicepantaleo, @martinamalberti, @missirol, @rovere, @thomreis, @wang0jin, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0cc87c/43206/summary.html
COMMIT: c07fd73
CMSSW: CMSSW_15_0_X_2024-12-03-1100/el8_amd64_gcc12
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46851/43206/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3484682
  • DQMHistoTests: Total failures: 400
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3484262
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

urgent

@cmsbuild cmsbuild added the urgent label Dec 3, 2024
@smuzaffar
Copy link
Contributor

@cms-sw/simulation-l2 , can you please review this?

@kpedro88
Copy link
Contributor

kpedro88 commented Dec 3, 2024

+simulation

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e96d4be into cms-sw:master Dec 3, 2024
14 checks passed
@mmusich mmusich deleted the mm_fix_CaloParticle branch December 3, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants