Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused L1TCaloSummary DQM sequences causing issues with HCAL. #46482

Merged
merged 4 commits into from
Oct 25, 2024
Merged

Remove unused L1TCaloSummary DQM sequences causing issues with HCAL. #46482

merged 4 commits into from
Oct 25, 2024

Conversation

aloeliger
Copy link
Contributor

PR description:

This PR removes two unused sequences in the CICADA DQM that were potentially causing duplicate TPs seen in HCAL tests. No DQM changes are expected as a result of this change.

Also changes Calo Summary DQM configuration to use GT digis instead of test crate digis, which is more correct.

@missirol FYI
@JHiltbrand Also FYI, but could I ask you to see if you can rerun the test you were looking at with this PR and see if this resolves the issue please?

PR validation:

Changed HCAL workflow was run-again to make sure that the sequence does not crash.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is not a backport, but may need backporting to online/offline DQM releases.

@aloeliger
Remove unused L1TCaloSummary sequences causing issues with HCAL.
d0756ec 
Also changes Calo Summary DQM configuration to use GT digis instead of test crate digis
@cmsbuild cmsbuild added this to the CMSSW_14_2_X milestone Oct 22, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 22, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46482/42337

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aloeliger for master.

It involves the following packages:

  • DQM/L1TMonitor (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@JHiltbrand
Copy link
Contributor

Hi @aloeliger ,

Thanks for making the PR, I will test this in the local workflow I have and report back

@JHiltbrand
Copy link
Contributor

Hi @aloeliger ,

I pulled your PR into my working area for 14_1_0, and reran my step3. I now find the number of processed HCAL TPs in the HcalDigis validation is exactly the same between 14_1_0+PR and 14_1_0_pre7 🎉

@aloeliger
Copy link
Contributor Author

Please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3bcdd1/42346/summary.html
COMMIT: d0756ec
CMSSW: CMSSW_14_2_X_2024-10-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46482/42346/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3566331
  • DQMHistoTests: Total failures: 808
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3565503
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 201 log files, 171 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

missirol
missirol reviewed Oct 22, 2024
View reviewed changes
DQM/L1TMonitor/python/L1TCaloLayer1Summary_cff.py Outdated
Comment on lines 9 to 10
simCaloStage2Layer1Digis.ecalToken = cms.InputTag("ecalDigis", "EcalTriggerPrimitives")
simCaloStage2Layer1Digis.hcalToken = cms.InputTag("hcalDigis", "")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for my understanding, why is it okay to let this DQM cff modify simCaloStage2Layer1Digis ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original simCaloStage2Layer1 is fed from simulated TPs. For emulation purposes here, it is likely better to have them fed from unpacked TPs, and look at the emulation results from that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a separate instance used solely for DQM purposes, or is this DQM cff modifying the results of the L1T emulation itself (similarly to what happened with the bug that this PR is trying to fix) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sequence should only be for DQM instances, but since it isn't cloned, it is likely causing the same problem, now that you mention it. I'll fix that.

@abdoulline
Copy link

abdoulline commented Oct 23, 2024 •
edited
Loading

Thanks.
N_TPs returned back to regular

Apparently needs to be backported at least to 14_0_X for coming 2024 MC 🤔

@vlimant
Copy link
Contributor

vlimant commented Oct 23, 2024

urgent

@vlimant
Copy link
Contributor

vlimant commented Oct 23, 2024

indeed, it would be great to have a backport to 14_0 and 14_1 asap. Even though it is clear at this point that there is no issue with the HCAL TP, but rather an issue in the validation procedure.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46482/42353

@aloeliger
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #46482 was updated. @aloeliger, @antoniovagnerini, @epalencia, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3bcdd1/42365/summary.html
COMMIT: 8574397
CMSSW: CMSSW_14_2_X_2024-10-23-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46482/42365/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3566343
  • DQMHistoTests: Total failures: 810
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3565513
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 201 log files, 171 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@antoniovagnerini
Copy link

Some differences are observed in the bin-by-bin comparison in the WF 12846.0 in HLT and 13034.0 in the HLT/L1T emulator, which were not present in the first round of tests with the PR. For instance in the HCALDigiTask for the WF 12846.0 (https://tinyurl.com/24sy4xno).
image and in L1Temulator for the 13034.0 WF Comparison GUI. In my understanding this PR shouldnt be modifying the results of the L1T emulation. Please confirm @missirol
image

@missirol
Copy link
Contributor

In my understanding this PR shouldnt be modifying the results of the L1T emulation.

In my understanding, it should modify them, restoring the correct ones (meaning, baseline results are bugged).

Please confirm @missirol

I'm not the relevant expert. I think the question should be directed to @cms-sw/l1-l2.

@missirol
Copy link
Contributor

Note that there is a comment to address in #46482 (comment).

@aloeliger
Copy link
Contributor Author

In my understanding this PR shouldnt be modifying the results of the L1T emulation.

In my understanding, it should modify them, restoring the correct ones (meaning, baseline results are bugged).

Please confirm @missirol

I'm not the relevant expert. I think the question should be directed to @cms-sw/l1-l2.

This is my understanding as well

@antoniovagnerini
Copy link

+dqm

@aloeliger
Copy link
Contributor Author

+l1

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 31e4882 into cms-sw:master Oct 25, 2024
11 checks passed
@mandrenguyen
Copy link
Contributor

merge
Not sure why L1's +1 is not registering, but it was signed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyigitba eyigitba eyigitba left review comments

@missirol missirol missirol left review comments

Assignees
No one assigned
Labels
code-checks-approved dqm-approved fully-signed l1-approved orp-approved tests-approved urgent
Projects
None yet
Milestone
CMSSW_14_2_X
Development

Successfully merging this pull request may close these issues.
9 participants
@aloeliger @cmsbuild @JHiltbrand @abdoulline @vlimant @antoniovagnerini @missirol @mandrenguyen @eyigitba