Adding unbiased superclusters to miniAOD and EGM nano #46423
+72
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46423/42282
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46423/42283
|
|
A new Pull Request was created by @SanghyunKo for master. It involves the following packages:
@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
enable nano |
|
please test |
|
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
hqucms
reviewed
Oct 17, 2024
| @@ -433,7 +433,7 @@ def _get_bitmapVIDForEle_docstring(modules,WorkingPoints): | |||
| electronTable.variables, | |||
| pt = Var("pt*userFloat('ecalTrkEnergyPostCorrNew')/userFloat('ecalTrkEnergyPreCorrNew')", float, precision=-1, doc="p_{T}"), | |||
| energyErr = Var("userFloat('ecalTrkEnergyErrPostCorrNew')", float, precision=6, doc="energy error of the cluster-track combination"), | |||
| eCorr = Var("userFloat('ecalTrkEnergyPostCorrNew')/userFloat('ecalTrkEnergyPreCorrNew')", float, doc="ratio of the calibrated energy/miniaod energy"), | |||
| ptPreCorr = Var("pt", float, doc="pt of the electron before energy corrections"), | |||
There was a problem hiding this comment.
Please update the nanoDQM with this change.
| @@ -283,7 +283,7 @@ def make_bitmapVID_docstring(id_modules_working_points_pset): | |||
| photonTable.variables, | |||
| pt = Var("pt*userFloat('ecalEnergyPostCorrNew')/userFloat('ecalEnergyPreCorrNew')", float, precision=-1, doc="p_{T}"), | |||
| energyErr = Var("userFloat('ecalEnergyErrPostCorrNew')",float,doc="energy error of the cluster from regression",precision=6), | |||
| eCorr = Var("userFloat('ecalEnergyPostCorrNew')/userFloat('ecalEnergyPreCorrNew')",float,doc="ratio of the calibrated energy/miniaod energy"), | |||
| ptPreCorr = Var("pt",float,doc="pt of the photon before energy corrections"), | |||
There was a problem hiding this comment.
Please update the nanoDQM with this change.
|
please test |
|
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR addresses two issues:
Replace the ratio between corrected & uncorrected energy in Run 2 NanoAOD with the uncorrected energy itself (to avoid issues like Replace buggy UL2016 EGM energy correction files #46046 - if the correction is 0, we cannot recover the energy before applying the correction using the ratio).
Currently, EGM still relies on AOD to derive central reco SFs. This is because the supercluster (SC) collection stored in MiniAOD is highly biased since we only store the SC that already reconstructed electron & photon objects. This PR attempts to improve the situation by migrating from the legacy AOD-based workflow to the (EGM) nanoAOD-based workflow. A minimal change in miniAOD is required to remove the biases implied in the current miniAOD.
PR validation:
The expected increase in miniAOD file size is marginal - from 0.07% for clean events (e.g. DY) to 0.44% for busy events (e.g. TTto4Q) when tested with 1k events. The increase in EGM nanoAOD due to the new SC collection is 1.16% in DY and 1.7% in TTto2L2Nu, again tested with 1k events (as of Winter24 samples).
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
No backport is needed (this PR targets Nano v15).