[UBSAN] Initialize PerigeeTrajectoryError::weightIsAvailable

[smuzaffar]

Initialize PerigeeTrajectoryError::weightIsAvailable for default constructor. This should fix UBSAN runtime errors [a]

[a] https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/raw/el8_amd64_gcc12/CMSSW_14_2_UBSAN_X_2024-10-11-2300/pyRelValMatrixLogs/run/13234.0_TTbar_14TeV+2021FS/step2_TTbar_14TeV+2021FS.log

TrackingTools/TrajectoryParametrization/interface/PerigeeTrajectoryError.h:14:7: runtime error: load of value 124, which is not a valid value for type 'bool'

TrackingTools/TrajectoryState/interface/TrajectoryStateClosestToPoint.h:18:7: runtime error: load of value 58, which is not a valid value for type 'bool'

[cmsbuild]

cms-bot internal usage

[smuzaffar]

test parameters:

• workflow = 13234.0,1337.0,136.759

[smuzaffar]

please test for CMSSW_14_2_UBSAN_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46380/42224

• There are other open Pull requests which might conflict with changes you have proposed:
  • File TrackingTools/TrajectoryParametrization/interface/PerigeeTrajectoryError.h modified in PR(s): Initialize member data in PerigeeTrajectoryError #46269

[cmsbuild]

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

• TrackingTools/TrajectoryParametrization (reconstruction)

@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @bellan, @dgulhan, @felicepantaleo, @gpetruc, @missirol, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3dd3ed/42170/summary.html
COMMIT: 1860735
CMSSW: CMSSW_14_2_UBSAN_X_2024-10-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46380/42170/install.sh to create a dev area with all the needed externals and cmssw changes.

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3dd3ed/42181/summary.html
COMMIT: 1860735
CMSSW: CMSSW_14_2_X_2024-10-14-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46380/42181/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 47
• DQMHistoTests: Total histograms compared: 3562427
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3562400
• DQMHistoTests: Total skipped: 24
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
• Checked 205 log files, 175 edm output root files, 47 DQM output files
• TriggerResults: no differences found

[smuzaffar]

@cms-sw/reconstruction-l2 , can you please review this. This should fix ubsan runtime errors [a]

[a] https://cmssdt.cern.ch/SDT/jenkins-artifacts/ubsan_logs/CMSSW_14_2_X_2024-10-11-2300/

12 TrackingTools/TrajectoryParametrization/interface/PerigeeTrajectoryError.h:14:7: runtime error: load of value 124, which is not a valid value for type 'bool'
2 TrackingTools/TrajectoryState/interface/TrajectoryStateClosestToPoint.h:18:7: runtime error: load of value 58, which is not a valid value for type 'bool' 

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1