Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Muon POG DQM sequence from Express pipeline - backport to 14_0_X #46298

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

rseidita
Copy link
Contributor

@rseidita rseidita commented Oct 8, 2024

PR description:

Removing Muon POG DQM sequence from Express pipeline to reduce memory load at T0.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #46293

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2024

A new Pull Request was created by @rseidita for CMSSW_14_0_X.

It involves the following packages:

  • DQMOffline/Configuration (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@rociovilar, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2024

cms-bot internal usage

@fabiocos
Copy link
Contributor

fabiocos commented Oct 8, 2024

please test

@fabiocos
Copy link
Contributor

fabiocos commented Oct 8, 2024

please abort

@fabiocos
Copy link
Contributor

fabiocos commented Oct 8, 2024

please test workflow 1001.3,1001.4

@antoniovagnerini
Copy link

backport of #46293

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2024

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28f3c4/42038/summary.html
COMMIT: 37ee6da
CMSSW: CMSSW_14_0_X_2024-10-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46298/42038/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 6 lines to the logs
  • Reco comparison results: 45 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3364136
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3364110
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 212 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1c11a4d into cms-sw:CMSSW_14_0_X Oct 8, 2024
9 checks passed
@rseidita rseidita deleted the muon_express_14_0_X branch October 8, 2024 18:21
@@ -158,7 +158,7 @@


DQMOfflinePrePOGExpress = cms.Sequence( DQMOfflineTracking *
DQMOfflineMUO *
Copy link
Contributor

@mmusich mmusich Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DQMOfflineMUO = cms.Sequence(muonMonitors)

and

muonMonitors = cms.Sequence(muonTrackAnalyzers*
cscMonitor*
muonAnalyzer*
muonIdDQM*
dqmInfoMuons*
muIsoDQM_seq)

and finally

cscMonitor = DQMEDAnalyzer('CSCOfflineMonitor',

I think this removed more than it was meant to (see https://cms-talk.web.cern.ch/t/missing-folder-in-streamexpress-run2024i-express-v2-dqmio/52718/1). @fabiocos @ptcox

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I missed this, will fix it ASAP. Apologies.

cmsbuild added a commit that referenced this pull request Oct 14, 2024
[Backport 140X] DQM: restore Muon POG sequence (and CSC Monitor), revert #46298
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants