Initialize all member data in PropagateToMuon

[Dr15Jones]

PR description:

Initialized all member data. UBSAN reported cases where data was being read before it was set.

PR validation:

Code compiles.

[Dr15Jones]

@makortel FYI

[Dr15Jones]

please test

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46242/42061

[cmsbuild]

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

• MuonAnalysis/MuonAssociators (analysis)

@tvami can you please review it and eventually sign? Thanks.
@CeliaFernandez, @Fedespring, @HuguesBrun, @abbiendi, @andrea21z, @battibass, @bellan, @cericeci, @jhgoh, @trocino this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: ClangBuild
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c67fb/41930/summary.html
COMMIT: 454dbf6
CMSSW: CMSSW_14_2_X_2024-10-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46242/41930/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46242/42062

[cmsbuild]

Pull request #46242 was updated. @tvami can you please check and sign again.

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c67fb/41931/summary.html
COMMIT: fc74c20
CMSSW: CMSSW_14_2_X_2024-10-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46242/41931/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 2022.1000012022.100001_RunJetHT2022C_10k/step1_dasquery.log
• 2022.1010012022.101001_RunEGamma2022C_10k/step1_dasquery.log
• 2023.0000012023.000001_RunMuonEG2023C_10k/step1_dasquery.log

Expand to see more relval errors ...

• 2024.000001
• 2022.100001
• 2022.101001
• 2023.000001
• 2024.000001

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 101 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331336
• DQMHistoTests: Total failures: 2912
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3328404
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[tvami]

@cmsbuild , please test

• altho the issue is not connected

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c67fb/41952/summary.html
COMMIT: fc74c20
CMSSW: CMSSW_14_2_X_2024-10-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46242/41952/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 105 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331336
• DQMHistoTests: Total failures: 3234
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3328082
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[tvami]

+1

• technical

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1