[DB] Ad a small feature to DT calibration payloads dumper #46224
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46224/42033 |
|
A new Pull Request was created by @battibass for master. It involves the following packages:
@atpathak, @cmsbuild, @consuegs, @perrotta can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
battibass
changed the title
| @@ -38,28 +38,32 @@ DumpDBToFile::DumpDBToFile(const ParameterSet& pset) { | |||
| if (format != "Legacy" && format != "DTRecoConditions") | |||
| throw cms::Exception("IncorrectSetup") << "Parameter format is not valid, check the cfg file" << endl; | |||
|
|
|||
| auto esConsumesByLabel = [&](auto& token) { | |||
There was a problem hiding this comment.
Since you are naming it now, why not something like
| auto esConsumesByLabel = [&](auto& token) { | |
| auto esConsumesWithLabel = [&](auto& token) { |
(in order not to get confused with the old fashioned getByLabel)?
battibass
force-pushed
the
dtcalib_dumper_fix
branch
from
34beb4d
to
cda07a5
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46224/42039 |
|
please test |
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
|
+alca |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Adda to a dumper program, used to perform checks on DT conditions, the possibility to inspect payloads tagged with specific labels.
PR validation:
This change does not affect any central workflow. The code compiles and the new feature was tested by dumping a small set of DT conditions.