Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIMULATION] Applying code checks/format #46213

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

smuzaffar
Copy link
Contributor

This PR applies clang-format and clang checks to source files which were missed during previous code-format campaigns.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2024

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • DataFormats/GeometryVector (simulation)
  • SimCalorimetry/EcalElectronicsEmulation (simulation)

@civanch, @cmsbuild, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@ReyerBand, @argiro, @missirol, @mmusich, @rchatter, @rovere, @sameasy, @thomreis, @wang0jin this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2024

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e39d5/41917/summary.html
COMMIT: 22069dc
CMSSW: CMSSW_14_2_X_2024-10-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46213/41917/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@civanch
Copy link
Contributor

civanch commented Oct 3, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 26130a1 into cms-sw:master Oct 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants