Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.1.X] Fix HLT Phase2 timing script. #46193

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 2, 2024

backport of #46185

PR description:

This should fix the script and profit of the new features added to the underlying benchmark script.

PR validation:

successfully tested in master

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #46185 to CMSSW_14_1_X.

@mmusich
Copy link
Contributor Author

mmusich commented Oct 2, 2024

enable hlt_p2_timing

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2024

A new Pull Request was created by @mmusich for CMSSW_14_1_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @missirol, @rovere, @silviodonato this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Oct 2, 2024

@cmsbuild, please test

@rovere
Copy link
Contributor

rovere commented Oct 2, 2024

@mmusich thanks for the backport!!

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-40cb51/41867/summary.html
COMMIT: ef5d4ed
CMSSW: CMSSW_14_1_X_2024-10-01-2300/el8_amd64_gcc12
Additional Tests: HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46193/41867/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich
Copy link
Contributor Author

mmusich commented Oct 2, 2024

type bug-fix

@mmusich
Copy link
Contributor Author

mmusich commented Oct 2, 2024

+hlt

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4627006 into cms-sw:CMSSW_14_1_X Oct 2, 2024
10 checks passed
@mmusich mmusich deleted the rovere_FixHLTP2TimingScript_14_1_X branch October 2, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants