[CORE] Remove unused python scripts in FWCore/MessageService/test/PsetValidationSamples

[iarspider]

PR description:

Fix syntax in python scripts:

• Switch to python 3 syntax: print(), except ... as
• Partial fix for indentation: make all indented line use the same characters for indentation (either spaces or tabs), remove mixing of tabs and spaces
• Add missing braces and commas, fix invalid syntax (FWLiteEnabler::enable() should be ROOT.FWLiteEnabler.enable()), remove trailing semicolons
• Replaced (potentially unsafe) exec with import_module

This is a preparation for fixing #46113 . Maybe some of these scripts are not needed anymore and can be removed?

PR validation:

Bot tests.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46168/41966

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• FWCore/MessageService (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[makortel]

@Dr15Jones @wddgit Do you know if the files in FWCore/MessageService/test/PsetValidationSamples/ are used for anything? By quick git grep I didn't see any indication they would be used by anything (and clearly the debugModules_cfg.py is not used).

Could we consider removing all these? Or are these meant as examples?

[makortel]

After looking a bit more detail, it seems these files were added in 546e000 as a very manual test (one would have to edit the files, and check the output). I'd bet these files are practically useless now, and would be best to be removed.

@iarspider Could you remove the directory FWCore/MessageService/test/PsetValidationSamples/ instead?

[iarspider]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46168/41979

[cmsbuild]

Pull request #46168 was updated. @Dr15Jones, @makortel, @smuzaffar can you please check and sign again.

[makortel]

Thanks. Could you also update the PR title?

[wddgit]

I wasn't aware these files existed. I agree that deleting is probably the best choice.

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df93c3/41844/summary.html
COMMIT: b568f40
CMSSW: CMSSW_14_2_X_2024-10-01-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46168/41844/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 32 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331342
• DQMHistoTests: Total failures: 1436
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3329886
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[makortel]

Comparison differences are related to #39803

[makortel]

+core

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1