Initialize all member data in CaloSD constructor

[Dr15Jones]

PR description:

UBSAN warned that the value for doFineCaloThisStep_ was begin read before it was set.

The warning was

SimG4CMS/Calo/src/CaloSD.cc:667:8: runtime error: load of value 95, which is not a valid value for type 'bool'

PR validation:

Code compiles.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46162/41959

[cmsbuild]

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

• SimG4CMS/Calo (simulation)

@civanch, @cmsbuild, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@ReyerBand, @bsunanda, @fabiocos, @felicepantaleo, @martinamalberti, @rovere, @slomeo, @thomreis, @wang0jin this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

please test

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d940dd/41819/summary.html
COMMIT: 255070e
CMSSW: CMSSW_14_2_X_2024-09-30-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46162/41819/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 41 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331342
• DQMHistoTests: Total failures: 3453
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3327869
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[civanch]

+1

Regression problems in MKFit not related to this PR.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1