Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usePCACleaning to CLUE3DHighStep_cff and fix HFNose seeded region #46152

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

Moanwar
Copy link
Contributor

@Moanwar Moanwar commented Sep 30, 2024

This PR updates the HFNose module in PatternRecognitionbyCA to protect it from events without seeding regions and adds usePCACleaning to CLUE3DHighStep_cff.

It fixes the issue found in PR #45821 and should be tested with D115, workflow 32034.0.

Tagging @felicepantaleo @waredjeb @hatakeyamak

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 30, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Moanwar for master.

It involves the following packages:

  • RecoHGCal/TICL (reconstruction, upgrade)

@Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@apsallid, @felicepantaleo, @forthommel, @hatakeyamak, @lecriste, @missirol, @rovere, @sameasy, @sobhatta, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Sep 30, 2024

test parameters:

  • relvals_opt = --what upgrade
  • workflow = 32034.0

@mmusich
Copy link
Contributor

mmusich commented Sep 30, 2024

type bug-fix

@mmusich
Copy link
Contributor

mmusich commented Sep 30, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c65aa/41813/summary.html
COMMIT: bc50877
CMSSW: CMSSW_14_2_X_2024-09-30-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46152/41813/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
32034.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 1028 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 128 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3331342
  • DQMHistoTests: Total failures: 4437
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3326885
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 196 log files, 167 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@Moanwar
Copy link
Contributor Author

Moanwar commented Sep 30, 2024

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ca7a9e9 into cms-sw:master Oct 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants