Bugfix in simulation of scintillator noise at startup #46142
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46142/41936 |
|
A new Pull Request was created by @mmfsz for master. It involves the following packages:
@Moanwar, @civanch, @cmsbuild, @kpedro88, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
| @@ -240,7 +240,7 @@ def HGCal_setRealisticStartupNoise(process): | |||
| (for instance turning on the 0th bit turns off the impact of fluence in Si) | |||
| """ | |||
| process=HGCal_setRealisticNoiseSi(process,byDose=True,byDoseAlgo=1) | |||
| process=HGCal_setRealisticNoiseSci(process,byDose=True,byDoseAlgo=2+8+16,referenceIdark=0.125,referenceXtalk=0.01) | |||
| process=HGCal_setRealisticNoiseSci(process,byDose=True,byDoseAlgo=2+16+32,byDoseFactor=0,referenceIdark=0.125,referenceXtalk=0.01) | |||
There was a problem hiding this comment.
can you provide some explanation of the meaning of the numerical values in byDoseAlgo? (either in a comment, or by turning these into individually named variables rather than magic numbers)
There was a problem hiding this comment.
The meaning of the bits is explained in the header file: https://github.com/cms-sw/cmssw/blob/master/SimCalorimetry/HGCalSimAlgos/interface/HGCalSciNoiseMap.h#L14-L21
The bug was that previously 8 was suppressing the scaling of the signal light yield with the tile area - definitely not what we want. 32 is added at startup as it will force to ignore the the scaling of the noise with the fluence (and signal with dose).
|
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Expand to see more relval errors ...
Comparison SummarySummary:
|
|
please test |
|
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
|
|
+1 |
|
+Upgrade |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
This PR fixes a bug in the settings for the simulation of the noise in the HGCal scintillator region for the startup scenario. The scaling of the noise by the dose factor was not being turned off for the startup scenario. The bug was discovered after looking at hits and occupancies in the scintillator region [1]. The fix was validated by comparing samples produced with the new settings and samples produced with the old settings but with the flags to ignore the effect of dose and fluence. The results were shown to agree, validating the new settings.
[1] https://indico.cern.ch/event/1413991/#9-occupancy-studies-in-the-sip