Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix minimum of the di-muon mass window in the Z->mm validation tool #46134

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 26, 2024

PR description:

It was recently noticed by @TomasKello that the default mass window range in the python configuration of the ZMuMu validation tool was in the range [80-120] GeV.
Restricting the mass fits in this asymmetric region around the Z mass peak ends up biasing the output fit parameters, as illustrated e.g. this plot:

Screenshot from 2024-09-26 15-40-41

This in turn created some unphysical features in the distribution of the invariant mass peak position as a function of the muon kinematic that are used to validate the various alignments.
The goal of this PR is to allow the fit to cover the whole region [60-120] GeV as default value in the all-in-one tool configuration, as already done in the fillDescriptions method of the plugin, see:

desc.add<double>("Pair_mass_min", 60.);
desc.add<double>("Pair_mass_max", 120.);

PR validation:

The tool was run in the vanilla release and the newly proposed defaults.

Default This PR
image image

as it can be seen unphysical bin by bin oscillations are removed.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported town to CMSSW_14_0_X.

@mmusich
Copy link
Contributor Author

mmusich commented Sep 26, 2024

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 26, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Sep 26, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Alignment/OfflineValidation (alca)

@atpathak, @consuegs, @perrotta can you please review it and eventually sign? Thanks.
@adewit, @mmusich, @rsreds, @tlampen, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-afe204/41768/summary.html
COMMIT: c520996
CMSSW: CMSSW_14_2_X_2024-09-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46134/41768/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 17 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3331342
  • DQMHistoTests: Total failures: 1389
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3329933
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 193 log files, 163 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants