Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for recent raw data format test PR #46105

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Sep 23, 2024

PR description:

This is related to recent PR #46044 which added split level 0 input files to some raw data format unit tests. A function that causes some StreamerInfo's to be explicitly loaded was being run for all the Run3Scouting tests, but the original intent was to only do that in the one case where it was necessary, in the split level 0 CMSSW_12_4_0 case. With this PR the unit tests behave as intended. This explicit load is related to the ROOT bug that affected releases 12_4_0 and 13_0_0 (see #43175).

I also noticed the new split level 0 tests were fast cloning. Although the read EDAnalyzer does the primary test, we get some extra test coverage by running the output module. With fast cloning the schema evolution is not run for the output module. This PR explicitly turns off fast cloning.

I also removed the "-ex" argument (top line in the shell scripts) to make the output less verbose.

This only affects the raw data format unit tests. It does not affect the actual data formats, any code run in production, or any other tests.

PR validation:

The affected unit tests pass.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 23, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wddgit for master.

It involves the following packages:

  • DataFormats/Common (core)
  • DataFormats/DetId (simulation)
  • DataFormats/FEDRawData (daq)
  • DataFormats/HLTReco (hlt)
  • DataFormats/L1Scouting (daq)
  • DataFormats/L1ScoutingRawData (daq)
  • DataFormats/L1TGlobal (l1)
  • DataFormats/Scouting (core)
  • DataFormats/SiStripCluster (reconstruction)

@Dr15Jones, @Martin-Grunewald, @aloeliger, @civanch, @cmsbuild, @emeschi, @epalencia, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @mmusich, @smorovic, @smuzaffar can you please review it and eventually sign? Thanks.
@Mmiglio, @VinInn, @alesaggio, @dinyar, @echabert, @fabiocos, @jlidrych, @makortel, @missirol, @mmusich, @robervalwalsh, @rovere, @silviodonato, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@wddgit
Copy link
Contributor Author

wddgit commented Sep 23, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01c433/41715/summary.html
COMMIT: 633c8ae
CMSSW: CMSSW_14_2_X_2024-09-23-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46105/41715/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3331116
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3331093
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 193 log files, 163 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@smorovic
Copy link
Contributor

+daq

@civanch
Copy link
Contributor

civanch commented Sep 24, 2024

+simulation

@mmusich
Copy link
Contributor

mmusich commented Sep 24, 2024

+hlt

@jfernan2
Copy link
Contributor

+1

@aloeliger
Copy link
Contributor

+l1

@makortel
Copy link
Contributor

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2cf9427 into cms-sw:master Sep 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants