-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for recent raw data format test PR #46105
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46105/41896 |
A new Pull Request was created by @wddgit for master. It involves the following packages:
@Dr15Jones, @Martin-Grunewald, @aloeliger, @civanch, @cmsbuild, @emeschi, @epalencia, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @mmusich, @smorovic, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Size: This PR adds an extra 32KB to repository Comparison SummarySummary:
|
+daq |
+simulation |
+hlt |
+1 |
+l1 |
+core |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This is related to recent PR #46044 which added split level 0 input files to some raw data format unit tests. A function that causes some StreamerInfo's to be explicitly loaded was being run for all the Run3Scouting tests, but the original intent was to only do that in the one case where it was necessary, in the split level 0 CMSSW_12_4_0 case. With this PR the unit tests behave as intended. This explicit load is related to the ROOT bug that affected releases 12_4_0 and 13_0_0 (see #43175).
I also noticed the new split level 0 tests were fast cloning. Although the read EDAnalyzer does the primary test, we get some extra test coverage by running the output module. With fast cloning the schema evolution is not run for the output module. This PR explicitly turns off fast cloning.
I also removed the "-ex" argument (top line in the shell scripts) to make the output less verbose.
This only affects the raw data format unit tests. It does not affect the actual data formats, any code run in production, or any other tests.
PR validation:
The affected unit tests pass.