Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data processing tests generation Tier-0 configurations #46103

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

germanfgv
Copy link
Contributor

PR description:

I'm updating T0 test scripts so they are more useful to T0 operators and users. This involves three changes that I'm introducing in this PR:

  • Fix test scripts multi-threading after changes introduced in argparse migration for cmsDriver and FWCore #43042.
    • Add tests for multi-treading in both scripts
  • Allow for Express processing of directly from streamer files, as this is the default mode of operations in Tier-0
    • Add test for this new feature
  • Use '+' as separator for RunAlcaSkimming.py and RunAlcaSkimming.py, as is already done with the other test scripts
    • Update related automatic tests.

PR validation:

Running scram b runtests shows no issues

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 23, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @germanfgv for master.

It involves the following packages:

  • Configuration/DataProcessing (operations)

@antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @mandrenguyen, @rappoccio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Co-authored-by: Marco Musich <marco.musich@cern.ch>
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #46103 was updated. @antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @mandrenguyen, @rappoccio can you please check and sign again.

@antoniovilela
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d7d6a2/41778/summary.html
COMMIT: fdd9338
CMSSW: CMSSW_14_2_X_2024-09-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46103/41778/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 6 lines to the logs
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3331342
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3331317
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 193 log files, 163 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@germanfgv
Copy link
Contributor Author

@antoniovilela, @davidlange6, @fabiocos, @mandrenguyen, @rappoccio I think the PR looks good. Could you review and sign if you agree?

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit cc3a20c into cms-sw:master Oct 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants