Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[L1] [PY312] String formatting to fix SyntaxWarning #46098

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Sep 23, 2024

This should fix the Python 3.12 SyntaxWarning: invalid escape sequence warnings. These changes also work for python 3.9 (cmssw default python)

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 23, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • EventFilter/L1TXRawToDigi (l1)
  • L1Trigger/L1TCalorimeter (l1)

@aloeliger, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @battibass, @missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar smuzaffar changed the title [L1] [PY312] String formating to fix SyntaxWarning [L1] [PY312] String formatying to fix SyntaxWarning Sep 23, 2024
@smuzaffar smuzaffar changed the title [L1] [PY312] String formatying to fix SyntaxWarning [L1] [PY312] String formatting to fix SyntaxWarning Sep 23, 2024
@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fdff25/41702/summary.html
COMMIT: 3ef1d3f
CMSSW: CMSSW_14_2_X_2024-09-22-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46098/41702/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4557e75 into cms-sw:master Sep 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants