Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NanoAOD] Remove Jet ID #46085

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

nurfikri89
Copy link
Contributor

PR description:

This PR removes AK4 and AK8 jet ID flag from NanoAOD. As the jet ID needs to be re-derived with the upcoming reMini+reNano, the available ID selections in NanoAOD gets outdated quickly. Analyzers will apply the jet ID selections on-the-fly and they can be applied from the jet constituent multiplicities and energy fractions. JME plans to provide a recipe to apply the jet ID through correctionlib .

PR validation:

  • passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos
  • passes MiniAOD workflows: runTheMatrix.py -i all --ibeos -l 2500.021,2500.022,2500.023,2500.024,2500.031,2500.032,2500.033,2500.034

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 21, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46085/41875

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @nurfikri89 for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @ftorrresd, @hqucms can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@hqucms
Copy link
Contributor

hqucms commented Sep 21, 2024

enable nano

@hqucms
Copy link
Contributor

hqucms commented Sep 21, 2024

please test

@hqucms
Copy link
Contributor

hqucms commented Sep 23, 2024

please abort

@hqucms
Copy link
Contributor

hqucms commented Sep 23, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-72dd5d/41708/summary.html
COMMIT: d11ac79
CMSSW: CMSSW_14_2_X_2024-09-22-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46085/41708/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 134 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3331038
  • DQMHistoTests: Total failures: 2085
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3328933
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.4429999999999997 KiB( 43 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -0.089 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 13234.0,... ): 0.020 KiB Physics/NanoAODDQM
  • Checked 193 log files, 163 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 666 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 243 differences found in the comparisons
  • DQMHistoTests: Total files compared: 21
  • DQMHistoTests: Total histograms compared: 55044
  • DQMHistoTests: Total failures: 272
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 54772
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -1.7059999999999997 KiB( 20 files compared)
  • DQMHistoSizes: changed ( 2500.001,... ): -0.322 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.011,... ): -0.214 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.101,... ): -0.089 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.111,... ): 0.020 KiB Physics/NanoAODDQM
  • Checked 102 log files, 58 edm output root files, 21 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001 2.941 2.927 0.013 ( +0.5% ) 2.95 3.13 -5.8% 6.059 6.039
2500.002 3.050 3.035 0.015 ( +0.5% ) 2.64 2.79 -5.6% 6.408 6.386
2500.003 2.995 2.979 0.016 ( +0.5% ) 2.78 2.91 -4.4% 6.387 6.367
2500.011 1.534 1.522 0.012 ( +0.8% ) 4.43 4.88 -9.1% 2.424 2.411
2500.012 2.032 2.014 0.018 ( +0.9% ) 2.78 2.90 -3.9% 2.606 2.603
2500.013 1.873 1.860 0.013 ( +0.7% ) 3.86 4.13 -6.4% 2.527 2.494
2500.021 0.022 0.022 0.000 ( +0.0% ) 0.90 0.99 -9.1% 2.353 2.174
2500.022 0.022 0.022 0.000 ( +0.0% ) 0.86 0.95 -9.1% 2.345 2.172
2500.023 0.022 0.022 0.000 ( +0.0% ) 0.84 0.94 -10.9% 2.217 2.126
2500.024 0.022 0.022 0.000 ( +0.0% ) 0.64 0.71 -10.0% 2.450 2.287
2500.031 0.035 0.035 0.000 ( +0.0% ) 0.80 0.85 -6.5% 2.403 2.281
2500.032 0.036 0.036 0.000 ( +0.0% ) 0.81 0.90 -10.1% 2.376 2.225
2500.033 0.037 0.037 0.000 ( +0.0% ) 0.72 0.80 -10.6% 2.460 2.317
2500.034 0.036 0.036 0.000 ( +0.0% ) 0.74 0.82 -9.5% 2.441 2.304
2500.101 2.732 2.720 0.011 ( +0.4% ) 8.13 9.01 -9.8% 6.955 6.287
2500.111 1.376 1.370 0.006 ( +0.4% ) 17.77 19.46 -8.7% 2.224 2.221
2500.112 1.795 1.789 0.006 ( +0.3% ) 12.98 14.52 -10.6% 2.305 2.126
2500.131 0.747 0.747 0.000 ( +0.0% ) 16.34 18.49 -11.6% 1.504 1.413
2500.201 2.557 2.547 0.010 ( +0.4% ) 7.02 7.75 -9.4% 6.233 5.524
2500.211 1.700 1.692 0.008 ( +0.5% ) 16.37 17.44 -6.1% 2.282 2.080
2500.212 2.096 2.089 0.007 ( +0.3% ) 12.84 14.04 -8.6% 2.364 2.139
2500.221 2.004 2.003 0.000 ( +0.0% ) 6.89 7.77 -11.3% 2.457 2.058
2500.222 3.281 3.271 0.010 ( +0.3% ) 6.76 7.61 -11.2% 2.541 2.092
2500.223 8.968 8.959 0.010 ( +0.1% ) 2.40 2.65 -9.3% 2.568 1.861
2500.224 5.787 5.728 0.059 ( +1.0% ) 0.56 0.61 -8.0% 2.378 1.961
2500.225 5.805 5.746 0.059 ( +1.0% ) 0.55 0.58 -5.5% 2.386 1.904
2500.226 3.044 3.034 0.010 ( +0.3% ) 6.81 7.37 -7.5% 2.537 2.160
2500.227 1.437 1.437 0.000 ( +0.0% ) 10.64 11.96 -11.1% 1.426 1.385
2500.231 1.404 1.403 0.000 ( +0.0% ) 12.89 13.66 -5.6% 2.190 1.677
2500.232 2.301 2.294 0.007 ( +0.3% ) 12.62 13.73 -8.1% 2.278 2.006
2500.233 4.748 4.741 0.007 ( +0.1% ) 3.92 4.25 -7.9% 2.285 2.012
2500.234 3.501 3.449 0.052 ( +1.5% ) 0.71 0.76 -5.9% 2.072 2.065
2500.235 3.513 3.460 0.053 ( +1.5% ) 0.70 0.75 -5.7% 2.087 2.126
2500.236 2.145 2.138 0.007 ( +0.3% ) 12.92 13.80 -6.4% 2.270 2.013
2500.237 1.016 1.016 0.000 ( +0.0% ) 15.48 16.82 -8.0% 1.464 1.327
2500.241 9.404 9.404 0.000 ( +0.0% ) 3.39 3.81 -11.2% 1.947 1.867
2500.242 10.331 10.331 0.000 ( +0.0% ) 0.79 0.91 -12.8% 1.726 1.653
2500.243 2.712 2.712 0.000 ( +0.0% ) 7.64 8.67 -11.8% 1.077 1.072
2500.244 485.976 485.976 0.000 ( +0.0% ) 0.50 0.57 -12.6% 1.681 1.682
2500.245 823.202 823.202 0.000 ( +0.0% ) 0.67 0.76 -12.2% 1.677 1.593
2500.901 1.777 1.777 0.000 ( +0.0% ) 19.32 21.39 -9.7% 1.844 1.791
2500.902 1.626 1.626 0.000 ( +0.0% ) 18.99 21.91 -13.3% 1.766 1.720
2500.911 13.995 13.995 0.000 ( +0.0% ) 3.36 3.10 +8.2% 1.095 1.095
2500.912 0.310 0.171 0.139 ( +81.2% ) 1.10 1.39 -21.4% 0.975 0.972
2500.913 0.110 0.110 0.000 ( +0.0% ) 1.00 1.18 -15.0% 0.977 0.976

@hqucms
Copy link
Contributor

hqucms commented Sep 23, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1e6ae4b into cms-sw:master Sep 24, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants