Fix "Called C++ object pointer is null" in ApvAnalysisFactory::constructAuxiliaryApvClasses

[iarspider]

PR description:

LLVM analyzer reports "Called C++ object pointer is null" in ApvAnalysisFactory::constructAuxiliaryApvClasses. This PR adds early return statements to avoid this.

PR validation:

Bot tests

[iarspider]

please test

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46074/41864

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• CalibTracker/SiStripAPVAnalysis (alca)

@consuegs, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@echabert, @gbenelli, @mmusich, @robervalwalsh, @rsreds, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1719e3/41665/summary.html
COMMIT: f20b065
CMSSW: CMSSW_14_2_X_2024-09-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46074/41665/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331158
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3331135
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[iarspider]

please test

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46074/41871

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46074/41871/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46074/41871/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[iarspider]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46074/41908

[cmsbuild]

Pull request #46074 was updated. @atpathak, @consuegs, @perrotta can you please check and sign again.

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1719e3/41736/summary.html
COMMIT: 05e8aa0
CMSSW: CMSSW_14_2_X_2024-09-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46074/41736/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 2022.0000012022.000001_RunJetHT2022B_10k/step1_dasquery.log
• 2022.000001DAS Error

Comparison Summary

Summary:

• You potentially removed 5 lines from the logs
• Reco comparison results: 137 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331070
• DQMHistoTests: Total failures: 5915
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3325135
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[perrotta]

+alca

• DAS error in the RelVal input test clearly uncorrelated

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1

[antoniovilela]

ignore tests-rejected with external-failure