Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HcalZDCDetId fix for Run3 [CMSSW_14_0_X] #46070

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

perrotta
Copy link
Contributor

PR description:

Fix of a bug in Run3 update of the HcalZDCDetId #43200
which prevented a proper serialization of the conditions for newly added Run3-specific ZDC readouts (RPD)

backport of #45033 (from @abdoulline)

PR validation:

Merged in CMSSW_14_1_X (and now also CMSSW_14_2_X) since a while

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 20, 2024

A new Pull Request was created by @perrotta for CMSSW_14_0_X.

It involves the following packages:

  • DataFormats/HcalDetId (simulation)

@civanch, @cmsbuild, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@abdoulline, @bsunanda, @mariadalfonso, @missirol, @mmusich, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 20, 2024

cms-bot internal usage

@perrotta
Copy link
Contributor Author

please test

@perrotta
Copy link
Contributor Author

backport of #45033

@vlimant
Copy link
Contributor

vlimant commented Sep 20, 2024

urgent

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f41ad2/41658/summary.html
COMMIT: 082f082
CMSSW: CMSSW_14_0_X_2024-09-19-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46070/41658/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@civanch
Copy link
Contributor

civanch commented Sep 21, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f9058e3 into cms-sw:CMSSW_14_0_X Sep 21, 2024
9 checks passed
@perrotta perrotta deleted the patch-1 branch September 21, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants