Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[phase2] add missing ESProducers to timing menu for running alpaka tracking #46060

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

lguzzi
Copy link
Contributor

@lguzzi lguzzi commented Sep 19, 2024

PR description:

Following #45508 , this PR adds three missing ESProducers to the timing menu of phase2 needed to run patatrack tracking with alpaka.

PR validation:

I have run the timing menu locally on lxplus, circles looks ok

cmsDriver.py Phase2 -s L1P2GT,HLT:75e33_timing --processName=HLTX \
  --conditions auto:phase2_realistic_T33 \
  --geometry Extended2026D110 \
  --era Phase2C17I13M9 \
  --eventcontent FEVTDEBUGHLT \
  --customise SLHCUpgradeSimulations/Configuration/aging.customise_aging_1000 \
  --filein file:output_Phase2_reL1T.root \
  --inputCommands='keep *, drop *_hlt*_*_HLT, drop triggerTriggerFilterObjectWithRefs_l1t*_*_HLT' \
  --mc --procModifiers alpaka \
  -n 100 --nThreads 1 --output={} 

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

not a backport

@lguzzi lguzzi changed the title add missing ESProducers to timing menu for running alpaka tracking [phase2] add missing ESProducers to timing menu for running alpaka tracking Sep 19, 2024
@cmsbuild cmsbuild added this to the CMSSW_14_2_X milestone Sep 19, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 19, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lguzzi for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @missirol, @mmusich, @rovere, @silviodonato this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Sep 19, 2024

@lguzzi, unrelated to the bug-fix

I have run the timing menu locally on lxplus, circles looks ok

can you explain what scenario corresponds to each one of the jsons uploaded?

@mmusich
Copy link
Contributor

mmusich commented Sep 19, 2024

enable hlt_p2_timing

@mmusich
Copy link
Contributor

mmusich commented Sep 19, 2024

@cmsbuild, please test

@lguzzi
Copy link
Contributor Author

lguzzi commented Sep 19, 2024

@lguzzi, unrelated to the bug-fix

I have run the timing menu locally on lxplus, circles looks ok

can you explain what scenario corresponds to each one of the jsons uploaded?

@mmusich ,
I have run three tests:

  • without the alpaka proc. modifier (Phase2_fullMenu_legacy_12sept2024 and Phase2_fullMenu_legacyv2_12sept2024), meaning legacy tracking
  • with the alpaka proc. modifier, which enables HGCAL reconstruction via alpaka, but with legacy tracking (ie. one commit before customiser for alpaka patatrack pixel seeding for phase2 #45508) (Phase2_fullMenu_alpakaNoTracking_12sept2024 and Phase2_fullMenu_alpakaNoTrackingv2_12sept2024)
  • with the alpaka proc. modifier on customiser for alpaka patatrack pixel seeding for phase2 #45508 (ie. patatrack tracking on alpaka) (Phase2_fullMenu_alpakaTracking_12sept2024 and Phase2_fullMenu_alpakaTrackingv2_12sept2024)

The json files without v2 in the name are run on Intel Xeon Processor Cascadelake, the files with v2 are run on Intel Xeon Processor Icelake.
As was said during the HLT Upgrade meeting this tuesday, running on lxplus is not meaningful, so these results are just tests and are not representative of the phase2 menu timing.

@mmusich
Copy link
Contributor

mmusich commented Sep 19, 2024

As was said during the HLT Upgrade meeting this tuesday, running on lxplus is not meaningful, so these results are just tests and are not representative of the phase2 menu timing.

OK, I missed the meeting unfortunately. Good to know, because I couldn't make any sense of them (-‿-")

@mmusich
Copy link
Contributor

mmusich commented Sep 19, 2024

test parameters:

  • relvals_opt = --what upgrade
  • workflows = 29634.751

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be264f/41632/summary.html
COMMIT: 63e7316
CMSSW: CMSSW_14_2_X_2024-09-19-1100/el8_amd64_gcc12
Additional Tests: HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46060/41632/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich
Copy link
Contributor

mmusich commented Sep 19, 2024

please test with #46064

@mmusich
Copy link
Contributor

mmusich commented Sep 19, 2024

+hlt

@mmusich
Copy link
Contributor

mmusich commented Sep 19, 2024

type bug-fix

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: #46064

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be264f/41644/summary.html
COMMIT: 63e7316
CMSSW: CMSSW_14_2_X_2024-09-19-1100/el8_amd64_gcc12
Additional Tests: HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46060/41644/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 22badb1 into cms-sw:master Sep 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants